[Findit] Modify result page to display tryjob result for test failure.

appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from common.git_repository import GitRepository
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from model import wf_analysis_status
 from model.wf_try_job import WfTryJob
 from pipeline_wrapper import BasePipeline
 from waterfall.try_job_type import TryJobType
@@ skipping 162 matching lines @@
     culprits = None
     if result and result.get('report'):
       if try_job_type == TryJobType.COMPILE:
         # For compile failures, the try job will stop if one revision fails, so
         # the culprit will be the last revision in the result.
         failed_revision = self._GetFailedRevisionFromCompileResult(
             result)
         failed_revisions = [failed_revision] if failed_revision else []
         culprits = self._GetCulpritInfo(failed_revisions)
         if culprits:
-          result['culprit'] = culprits[failed_revision]
+          result['culprit'] = {
+              'compile': culprits[failed_revisions[0]]

[stgao, 2016/02/02 21:08:33]

use failed_revision directly instead?

[chanli, 2016/02/02 22:18:13]

Done.

+          }
       else:  # try_job_type is 'test'.
         culprit_map, failed_revisions = self._FindCulpritForEachTestFailure(
             blame_list, result)
         culprits = self._GetCulpritInfo(failed_revisions)
         if culprits:
           self._UpdateCulpritMapWithCulpritInfo(culprit_map, culprits)
           result['culprit'] = culprit_map
 
     # Store try job results.
     try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
     if culprits:
       result_to_update = (
           try_job_result.compile_results if
           try_job_type == TryJobType.COMPILE else
           try_job_result.test_results)
       if (result_to_update and
           result_to_update[-1]['try_job_id'] == try_job_id):
         result_to_update[-1].update(result)
 
       else:  # pragma: no cover
         result_to_update.append(result)
 
     try_job_result.status = wf_analysis_status.ANALYZED
     try_job_result.put()
 
     return result.get('culprit', None) if result else None