Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: net/quic/crypto/proof_verifier_chromium.cc

Issue 1652603002: Add information to SSLInfo about CT EV policy compliance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rsleevi nits Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/net.gypi ('k') | net/quic/crypto/proof_verifier_chromium_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/crypto/proof_verifier_chromium.h" 5 #include "net/quic/crypto/proof_verifier_chromium.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/callback_helpers.h" 11 #include "base/callback_helpers.h"
12 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
13 #include "base/logging.h" 13 #include "base/logging.h"
14 #include "base/macros.h" 14 #include "base/macros.h"
15 #include "base/metrics/histogram_macros.h" 15 #include "base/metrics/histogram_macros.h"
16 #include "base/stl_util.h" 16 #include "base/stl_util.h"
17 #include "base/strings/stringprintf.h" 17 #include "base/strings/stringprintf.h"
18 #include "crypto/signature_verifier.h" 18 #include "crypto/signature_verifier.h"
19 #include "net/base/host_port_pair.h" 19 #include "net/base/host_port_pair.h"
20 #include "net/base/net_errors.h" 20 #include "net/base/net_errors.h"
21 #include "net/cert/asn1_util.h" 21 #include "net/cert/asn1_util.h"
22 #include "net/cert/cert_status_flags.h" 22 #include "net/cert/cert_status_flags.h"
23 #include "net/cert/cert_verifier.h" 23 #include "net/cert/cert_verifier.h"
24 #include "net/cert/cert_verify_result.h" 24 #include "net/cert/cert_verify_result.h"
25 #include "net/cert/ct_policy_enforcer.h" 25 #include "net/cert/ct_policy_enforcer.h"
26 #include "net/cert/ct_policy_status.h"
26 #include "net/cert/ct_verifier.h" 27 #include "net/cert/ct_verifier.h"
27 #include "net/cert/x509_certificate.h" 28 #include "net/cert/x509_certificate.h"
28 #include "net/cert/x509_util.h" 29 #include "net/cert/x509_util.h"
29 #include "net/http/transport_security_state.h" 30 #include "net/http/transport_security_state.h"
30 #include "net/log/net_log.h" 31 #include "net/log/net_log.h"
31 #include "net/quic/crypto/crypto_protocol.h" 32 #include "net/quic/crypto/crypto_protocol.h"
32 #include "net/ssl/ssl_config_service.h" 33 #include "net/ssl/ssl_config_service.h"
33 34
34 using base::StringPiece; 35 using base::StringPiece;
35 using base::StringPrintf; 36 using base::StringPrintf;
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 base::Unretained(this)), 278 base::Unretained(this)),
278 &cert_verifier_request_, net_log_); 279 &cert_verifier_request_, net_log_);
279 } 280 }
280 281
281 int ProofVerifierChromium::Job::DoVerifyCertComplete(int result) { 282 int ProofVerifierChromium::Job::DoVerifyCertComplete(int result) {
282 cert_verifier_request_.reset(); 283 cert_verifier_request_.reset();
283 284
284 const CertVerifyResult& cert_verify_result = 285 const CertVerifyResult& cert_verify_result =
285 verify_details_->cert_verify_result; 286 verify_details_->cert_verify_result;
286 const CertStatus cert_status = cert_verify_result.cert_status; 287 const CertStatus cert_status = cert_verify_result.cert_status;
288 verify_details_->ct_verify_result.ct_policies_applied =
289 (result == OK && policy_enforcer_ != nullptr);
290 verify_details_->ct_verify_result.ev_policy_compliance =
291 ct::EVPolicyCompliance::EV_POLICY_DOES_NOT_APPLY;
287 if (result == OK && policy_enforcer_ && 292 if (result == OK && policy_enforcer_ &&
288 (cert_verify_result.cert_status & CERT_STATUS_IS_EV)) { 293 (cert_verify_result.cert_status & CERT_STATUS_IS_EV)) {
289 if (!policy_enforcer_->DoesConformToCTEVPolicy( 294 ct::EVPolicyCompliance ev_policy_compliance =
295 policy_enforcer_->DoesConformToCTEVPolicy(
290 cert_verify_result.verified_cert.get(), 296 cert_verify_result.verified_cert.get(),
291 SSLConfigService::GetEVCertsWhitelist().get(), 297 SSLConfigService::GetEVCertsWhitelist().get(),
292 verify_details_->ct_verify_result, net_log_)) { 298 verify_details_->ct_verify_result.verified_scts, net_log_);
299 verify_details_->ct_verify_result.ev_policy_compliance =
300 ev_policy_compliance;
301 if (ev_policy_compliance !=
302 ct::EVPolicyCompliance::EV_POLICY_DOES_NOT_APPLY &&
303 ev_policy_compliance !=
304 ct::EVPolicyCompliance::EV_POLICY_COMPLIES_VIA_WHITELIST &&
305 ev_policy_compliance !=
306 ct::EVPolicyCompliance::EV_POLICY_COMPLIES_VIA_SCTS) {
293 verify_details_->cert_verify_result.cert_status |= 307 verify_details_->cert_verify_result.cert_status |=
294 CERT_STATUS_CT_COMPLIANCE_FAILED; 308 CERT_STATUS_CT_COMPLIANCE_FAILED;
295 verify_details_->cert_verify_result.cert_status &= ~CERT_STATUS_IS_EV; 309 verify_details_->cert_verify_result.cert_status &= ~CERT_STATUS_IS_EV;
296 } 310 }
297 } 311 }
298 312
299 // TODO(estark): replace 0 below with the port of the connection. 313 // TODO(estark): replace 0 below with the port of the connection.
300 if (transport_security_state_ && 314 if (transport_security_state_ &&
301 (result == OK || 315 (result == OK ||
302 (IsCertificateError(result) && IsCertStatusMinorError(cert_status))) && 316 (IsCertificateError(result) && IsCertStatusMinorError(cert_status))) &&
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 } 450 }
437 return status; 451 return status;
438 } 452 }
439 453
440 void ProofVerifierChromium::OnJobComplete(Job* job) { 454 void ProofVerifierChromium::OnJobComplete(Job* job) {
441 active_jobs_.erase(job); 455 active_jobs_.erase(job);
442 delete job; 456 delete job;
443 } 457 }
444 458
445 } // namespace net 459 } // namespace net
OLDNEW
« no previous file with comments | « net/net.gypi ('k') | net/quic/crypto/proof_verifier_chromium_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698