Add information to SSLInfo about CT EV policy compliance

net/cert/ct_policy_status.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef NET_CERT_CT_POLICY_STATUS_H

[Ryan Sleevi, 2016/02/18 06:46:51]

There's supposed to be a newline between 3 & 4 (and 

[estark, 2016/02/18 19:24:32]

Done.

+#define NET_CERT_CT_POLICY_STATUS_H
+
+namespace net {
+
+namespace ct {
+
+// Information about a connection's compliance with the CT EV
+// certificate policy.
+enum EVPolicyCompliance {

[Ryan Sleevi, 2016/02/18 06:46:51]

Do you want to enum class this so you can forward declare it? (This is permitted
in https://chromium-cpp.appspot.com/ )

[estark, 2016/02/18 19:24:32]

Done.

+  // The certificate was not EV, so the EV policy doesn't apply.
+  EV_POLICY_DOES_NOT_APPLY = 0,

[Ryan Sleevi, 2016/02/18 06:46:51]

Do you still need this explicit numbering?

If you do (e.g. because it is UMA'd), we should indicate that. Otherwise, if it
doesn't matter, we can just drop the = 0

[estark, 2016/02/18 19:24:31]

I think I started UMAing it in a follow-up CL. I'll drop the numbering here and
re-add it there with a comment.

+  // The connection complied with the EV certificate policy by being
+  // included on the EV whitelist.
+  EV_POLICY_COMPLIES_VIA_WHITELIST,
+  // The connection complied with the EV certificate policy by
+  // including SCTs that satisfy the policy.
+  EV_POLICY_COMPLIES_VIA_SCTS,
+  // The connection did not have enough SCTs to retain its EV
+  // status.
+  EV_POLICY_NOT_ENOUGH_SCTS,
+  // The connection did not have diverse enough SCTs to retain its
+  // EV status.
+  EV_POLICY_NOT_DIVERSE_SCTS,
+  // The connection cannot be considered compliant because the build
+  // isn't timely and therefore log information might be out of date
+  // (for example a log might no longer be considered trustworthy).
+  EV_POLICY_BUILD_NOT_TIMELY,
+};
+
+}  // namespace ct
+
+}  // namespace net
+
+#endif  // NET_CERT_CT_POLICY_STATUS_H