Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2971)

Unified Diff: chrome/browser/resources/settings/settings_shared.css

Issue 1652553002: [MD settings] adjusting heights of settings rows; removing two .css files; unifying settings layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_shared.css
diff --git a/chrome/browser/resources/settings/settings_shared.css b/chrome/browser/resources/settings/settings_shared.css
index 6f5b1f45600c257b71a7294089a3947f132598b5..291fd6ae6de7d05d87517fd57c17ed521174aa48 100644
--- a/chrome/browser/resources/settings/settings_shared.css
+++ b/chrome/browser/resources/settings/settings_shared.css
@@ -50,29 +50,34 @@ span ~ a {
.list-frame {
@apply(--layout-center);
display: block;
- margin-left: 48px;
- padding: 0;
+ padding: 0 20px 0 48px;
}
.list-frame select {
-webkit-margin-start: 4px;
}
+.list-frame .secondary {
+ color: #969696;
+}
+
.list-item {
@apply(--layout-center);
display: flex;
padding: 0;
}
-.list-item .middle {
+.list-item > .middle {
flex: 1;
margin: 8px 12px;
overflow: hidden;
white-space: nowrap;
}
-.list-item .secondary {
- color: #969696;
+.list-item > .start {
+ flex: 1;
+ overflow: hidden;
+ white-space: nowrap;
dpapad 2016/01/30 00:17:35 Do you also need text-overflow: ellipsis; here?
dschuyler 2016/01/30 01:46:56 I put this on my list to look into (for a later CL
}
.list-item > paper-icon-item {
@@ -91,17 +96,17 @@ span ~ a {
.settings-box {
@apply(--layout-center);
border-top: 1px solid #e0e0e0;
- display: block;
+ display: flex;
min-height: 40px;
- padding: 8px 16px;
+ padding: 0 20px;
}
.settings-box.first {
border-top: none;
}
-.settings-box.row {
- display: flex;
+.settings-box.block {
+ display: block;
}
.settings-box.two-line {
@@ -112,11 +117,7 @@ span ~ a {
color: #969696;
}
-.split {
- display: flex;
-}
-
-.split .start {
+.settings-box .start {
flex: auto;
}
« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698