chrome/browser/gtk/task_manager_gtk.cc - Issue 165253: gtk: Don't crash if the user double clicks an empty area of the task manager ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/task_manager_gtk.cc

Issue 165253: gtk: Don't crash if the user double clicks an empty area of the task manager ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/gtk/task_manager_gtk.cc

===================================================================

--- chrome/browser/gtk/task_manager_gtk.cc (revision 22930)

+++ chrome/browser/gtk/task_manager_gtk.cc (working copy)

@@ -552,8 +552,10 @@

// If the user has just double clicked, only one item is selected.

GtkTreeModel* model;

GList* selected = gtk_tree_selection_get_selected_rows(selection, &model);

- int row = GetRowNumForPath(reinterpret_cast<GtkTreePath*>(selected->data));

- task_manager_->ActivateProcess(row);

+ if (selected) {

+ int row = GetRowNumForPath(reinterpret_cast<GtkTreePath*>(selected->data));

+ task_manager_->ActivateProcess(row);

+ }

}

void TaskManagerGtk::OnLinkActivated() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »