Issue 16525003: Fix leak in SkFontHost_fontconfig temporary code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16525003: Fix leak in SkFontHost_fontconfig temporary code. (Closed)

Created:
7 years, 6 months ago by bungeman-skia

Modified:
7 years, 6 months ago

Reviewers:
robertphillips

CC:
skia-review_googlecode.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix leak in SkFontHost_fontconfig temporary code. Yet another issue with the SkMemoryStream constructor which doesn't free memory. The default boolean on the end needs to be kicked out and replaced non-default enum which specifies one of 'copy', 'callerPassesOwnership', or 'callerRetainsOwnership'.

Patch Set 1 #

Patch Set 2 : My fingers forgot to type 'detatch'. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/ports/SkFontHost_fontconfig.cpp	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed revision 4960.

Expand Messages | Collapse Messages