Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 165250: Merge 22799 - Set up a interposing library for Carbon calls made by plugins.... (Closed)

Created:
11 years, 4 months ago by jon
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan1
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), jam, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 22799 - Set up a interposing library for Carbon calls made by plugins. This gives us a library that's inserted into plugin process via DYLD_INSERT_LIBRARIES to intercept Carbon calls, and moves the window/process activation handling into that library (based on Carbon window activation/deactivation calls, rather than polling the front window). Over time we'll interpose more, but this gives us the foundation. This fixes both the "window loses focus when loading a page with plugins" and "can't click on YouTube controls" bugs. BUG=18203, 18553 TEST=Clicking on Flash plugins should work much more reliably, opening a page with a plugin shouldn't cause the window to lose focus. Review URL: http://codereview.chromium.org/164100 TBR=stuartmorgan@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-5 lines, -8271 lines) Patch
A + chrome/browser/plugin_carbon_interpose_mac.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM chrome/browser/plugin_process_host.cc View 1 chunk +0 lines, -612 lines 0 comments Download
MM chrome/chrome.gyp View 1 chunk +0 lines, -5242 lines 0 comments Download
A + chrome/common/plugin_carbon_interpose_constants_mac.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/plugin_carbon_interpose_constants_mac.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM chrome/plugin/plugin_main.cc View 1 chunk +0 lines, -114 lines 0 comments Download
A + webkit/glue/plugins/fake_plugin_window_tracker_mac.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/glue/plugins/fake_plugin_window_tracker_mac.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM webkit/glue/plugins/webplugin_delegate_impl_mac.mm View 1 chunk +0 lines, -609 lines 0 comments Download
MM webkit/webkit.gyp View 1 chunk +0 lines, -1699 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jon
11 years, 4 months ago (2009-08-10 19:19:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698