Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1652493002: Use request initiator to check for cross origin requests. (Closed)

Created:
4 years, 10 months ago by Marijn Kruisselbrink
Modified:
4 years, 10 months ago
Reviewers:
Mike West, horo
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use request initiator to check if a request is cross origin. With initiator() added to URLRequest there is no need to have different code for regular and foreign fetch for this check, making the code simpler. Committed: https://crrev.com/5ead27709174b374fb160b71b4702d6e99c07edb Cr-Commit-Position: refs/heads/master@{#372711}

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
Marijn Kruisselbrink
mkwst: I'm pretty sure initiator() is the right thing to use here, but since you ...
4 years, 10 months ago (2016-01-29 22:55:11 UTC) #4
horo
lgtm
4 years, 10 months ago (2016-02-01 03:47:29 UTC) #5
Mike West
With the caveat that I've only tested the initiator code on the subset of requests ...
4 years, 10 months ago (2016-02-01 06:32:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652493002/20001
4 years, 10 months ago (2016-02-01 17:54:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-02-01 19:06:23 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 19:07:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ead27709174b374fb160b71b4702d6e99c07edb
Cr-Commit-Position: refs/heads/master@{#372711}

Powered by Google App Engine
This is Rietveld 408576698