Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 1652483002: Browser Side Text Input State Tracking for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_delegate.h
diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h
index aa38066ec28b62ea9488ab6ddb2759cfa7d6bdbb..440584df74d55acb3ee717b478ad4c4c2d15201b 100644
--- a/content/browser/renderer_host/render_widget_host_delegate.h
+++ b/content/browser/renderer_host/render_widget_host_delegate.h
@@ -31,7 +31,9 @@ namespace content {
class BrowserAccessibilityManager;
class RenderWidgetHostImpl;
class RenderWidgetHostInputEventRouter;
+class RenderWidgetHostViewBase;
struct NativeWebKeyboardEvent;
+struct TextInputState;
//
// RenderWidgetHostDelegate
@@ -132,6 +134,16 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {
virtual RenderWidgetHostImpl* GetFocusedRenderWidgetHost(
RenderWidgetHostImpl* receiving_widget);
+ // Returns the current value of text input state. This should be the value
+ // obtained from the focused RWHV.
+ virtual const TextInputState* GetTextInputState();
+
+ // This method is called by any RWHV which receives an IPC regarding a change
+ // in the text input state. The IPC might or might not have lead to a change
+ // in state but this method must be called for IME related logic.
+ virtual void UpdateTextInputState(RenderWidgetHostViewBase* rwhv,
+ bool text_input_state_changed) {}
+
// Notification that the renderer has become unresponsive. The
// delegate can use this notification to show a warning to the user.
virtual void RendererUnresponsive(RenderWidgetHostImpl* render_widget_host) {}
@@ -167,12 +179,12 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {
// Notification that the widget has lost the mouse lock.
virtual void LostMouseLock(RenderWidgetHostImpl* render_widget_host) {}
- // Called when the widget has sent a compositor proto. This is used in Btlimp
+ // Called when the widget has sent a compositor proto. This is used in Blimp
// mode with the RemoteChannel compositor.
virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,
const std::vector<uint8_t>& proto) {}
- // Called when the visibility of the RenderFrameProxyHost in outter
+ // Called when the visibility of the RenderFrameProxyHost in outer
// WebContents changes. This method is only called on an inner WebContents and
// will eventually notify all the RenderWidgetHostViews belonging to that
// WebContents.

Powered by Google App Engine
This is Rietveld 408576698