Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 1652483002: Browser Side Text Input State Tracking for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_guest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc
index e90f44bd0b1374dbaaf8b8fcf1d0e9953c08ed78..41e31c0ac5e2bfd9561dcf0ac7009285675b2194 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.cc
+++ b/content/browser/frame_host/render_widget_host_view_guest.cc
@@ -348,18 +348,6 @@ void RenderWidgetHostViewGuest::SetIsLoading(bool is_loading) {
platform_view_->SetIsLoading(is_loading);
}
-void RenderWidgetHostViewGuest::TextInputStateChanged(
- const ViewHostMsg_TextInputState_Params& params) {
- if (!guest_)
- return;
-
- RenderWidgetHostViewBase* rwhv = GetOwnerRenderWidgetHostView();
- if (!rwhv)
- return;
- // Forward the information to embedding RWHV.
- rwhv->TextInputStateChanged(params);
-}
-
void RenderWidgetHostViewGuest::ImeCancelComposition() {
if (!guest_)
return;
@@ -506,6 +494,10 @@ void RenderWidgetHostViewGuest::DestroyGuestView() {
// processing calls coming in after we release host_.
NotifyObserversAboutShutdown();
+ // The WebContentsImpl should be notified about us so that it will not hold
+ // an invalid text input state which was due to active text on this view.
+ NotifyHostDelegateAboutShutdown();
+
host_->SetView(NULL);
host_ = NULL;
base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);

Powered by Google App Engine
This is Rietveld 408576698