Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 1652483002: Browser Side Text Input State Tracking for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index 59155ca03939c4faa35aee239641c2338ebfa4a6..73adb2e66a8023b249af5a70c191a0b747bf70a4 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -218,11 +218,6 @@ void RenderWidgetHostViewChildFrame::SetIsLoading(bool is_loading) {
NOTREACHED();
}
-void RenderWidgetHostViewChildFrame::TextInputStateChanged(
- const ViewHostMsg_TextInputState_Params& params) {
- // TODO(kenrb): Implement.
-}
-
void RenderWidgetHostViewChildFrame::RenderProcessGone(
base::TerminationStatus status,
int error_code) {
@@ -245,6 +240,10 @@ void RenderWidgetHostViewChildFrame::Destroy() {
// RenderWidgetHostInputEventRouter afterwards.
NotifyObserversAboutShutdown();
+ // If this view has an active text input, the RenderWidgetHostDelegate should
+ // be notified.
+ NotifyHostDelegateAboutShutdown();
+
host_->SetView(NULL);
host_ = NULL;
base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);

Powered by Google App Engine
This is Rietveld 408576698