Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mus.cc

Issue 1652483002: Browser Side Text Input State Tracking for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mus.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_mus.cc b/content/browser/renderer_host/render_widget_host_view_mus.cc
index ebd0f47268a07d7d562b17c27f9226dc92204ed9..4907f4b92501971c2ebd9bd968f426bef831af4b 100644
--- a/content/browser/renderer_host/render_widget_host_view_mus.cc
+++ b/content/browser/renderer_host/render_widget_host_view_mus.cc
@@ -13,6 +13,7 @@
#include "content/browser/renderer_host/render_process_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/common/render_widget_window_tree_client_factory.mojom.h"
+#include "content/common/text_input_state.h"
#include "content/public/common/mojo_shell_connection.h"
#include "mojo/shell/public/cpp/connector.h"
#include "ui/aura/client/screen_position_client.h"
@@ -124,6 +125,10 @@ void RenderWidgetHostViewMus::RenderProcessGone(base::TerminationStatus status,
}
void RenderWidgetHostViewMus::Destroy() {
+ // The WebContentsImpl should be notified about us so that it will not hold
+ // an invalid text input state which was due to active text on this view.
+ NotifyHostDelegateAboutShutdown();
+
delete aura_window_;
}
@@ -187,9 +192,9 @@ void RenderWidgetHostViewMus::UpdateCursor(const WebCursor& cursor) {
void RenderWidgetHostViewMus::SetIsLoading(bool is_loading) {
}
-void RenderWidgetHostViewMus::TextInputStateChanged(
- const ViewHostMsg_TextInputState_Params& params) {
- // TODO(fsamuel): Implement an IME mojo app.
+void RenderWidgetHostViewMus::UpdateInputMethodIfNecessary(
+ bool text_input_state_changed) {
+ // TODO: Implement the IME logic when input state changes.
}
void RenderWidgetHostViewMus::ImeCancelComposition() {

Powered by Google App Engine
This is Rietveld 408576698