Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 1652483002: Browser Side Text Input State Tracking for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a Compile Error Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_delegate.h
diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h
index 9d20ade40ed8024f7ab1a40fc388d8fdd920a073..141d6247ff0bb58a3619e7487e5d561b84cca4ba 100644
--- a/content/browser/renderer_host/render_widget_host_delegate.h
+++ b/content/browser/renderer_host/render_widget_host_delegate.h
@@ -11,6 +11,7 @@
#include "build/build_config.h"
#include "content/common/content_export.h"
+#include "content/common/text_input_state.h"
#include "third_party/WebKit/public/platform/WebDisplayMode.h"
#include "third_party/WebKit/public/web/WebInputEvent.h"
#include "ui/gfx/native_widget_types.h"
@@ -31,6 +32,7 @@ namespace content {
class BrowserAccessibilityManager;
class RenderWidgetHostImpl;
class RenderWidgetHostInputEventRouter;
+class RenderWidgetHostViewBase;
struct NativeWebKeyboardEvent;
//
@@ -133,6 +135,16 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {
virtual RenderWidgetHostImpl* GetFocusedRenderWidgetHost(
RenderWidgetHostImpl* receiving_widget);
+ // Returns the current value of text input state. This should be the value
+ // obtained from the focused RWHV.
Charlie Reis 2016/03/15 18:32:00 nit: Remove extra space.
EhsanK 2016/03/15 23:51:17 Done. Thanks!
+ virtual TextInputState GetTextInputState();
+
+ // This method is called by any RWHV which receives an IPC regarding a change
+ // in the text input state. The IPC could or could not have lead to a change
Charlie Reis 2016/03/15 18:32:00 nit: s/could/might/g
EhsanK 2016/03/15 23:51:17 Done. Thanks!
+ // in state but this method must be called for IME related logic.
+ virtual void UpdateTextInputState(RenderWidgetHostViewBase* rwhv,
+ bool text_input_state_changed);
+
// Notification that the renderer has become unresponsive. The
// delegate can use this notification to show a warning to the user.
virtual void RendererUnresponsive(RenderWidgetHostImpl* render_widget_host) {}
@@ -172,12 +184,12 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {
virtual gfx::NativeViewAccessible GetParentNativeViewAccessible();
#endif
- // Called when the widget has sent a compositor proto. This is used in Btlimp
+ // Called when the widget has sent a compositor proto. This is used in Blimp
// mode with the RemoteChannel compositor.
virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,
const std::vector<uint8_t>& proto) {}
- // Called when the visibility of the RenderFrameProxyHost in outter
+ // Called when the visibility of the RenderFrameProxyHost in outer
// WebContents changes. This method is only called on an inner WebContents and
// will eventually notify all the RenderWidgetHostViews belonging to that
// WebContents.

Powered by Google App Engine
This is Rietveld 408576698