content/browser/frame_host/render_widget_host_view_child_frame.h - Issue 1652483002: Browser Side Text Input State Tracking for OOPIF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.h

Issue 1652483002: Browser Side Text Input State Tracking for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_widget_host_view_child_frame.h

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.h b/content/browser/frame_host/render_widget_host_view_child_frame.h

index c77b216b229ced95bdb1745c45adcd44515e7205..b412571d3dda67c04e1e616cc80ec4eabd621e6f 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.h

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.h

@@ -84,8 +84,8 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame

void MovePluginWindows(const std::vector<WebPluginGeometry>& moves) override;

void UpdateCursor(const WebCursor& cursor) override;

void SetIsLoading(bool is_loading) override;

- void TextInputStateChanged(

- const ViewHostMsg_TextInputState_Params& params) override;

+ void NotifyTextInputStateChanged() override;

+ bool ShouldObtainTextInputStateFromSubFrameViews() const override;

kenrb 2016/02/01 20:12:43 nit: SubFrame should be ChildFrame, to keep termin

EhsanK 2016/02/12 15:46:59 Done.

void ImeCancelComposition() override;

void ImeCompositionRangeChanged(

const gfx::Range& range,