Browser Side Text Input State Tracking for OOPIF.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 1653 matching lines @@
   // the subframe has focus.  Drop the event in that case.  Do not give
   // it to the main frame, so that the user doesn't unexpectedly type into the
   // wrong frame if a focused subframe renderer crashes while they type.
   RenderWidgetHostView* view = focused_frame->current_frame_host()->GetView();
   if (!view)
     return nullptr;
 
   return RenderWidgetHostImpl::From(view->GetRenderWidgetHost());
 }
 
+RenderWidgetHostViewBase* WebContentsImpl::GetFocusedView() {
+  FrameTreeNode* focused_frame = frame_tree_.GetFocusedFrame();
+  if (!focused_frame)
+    return nullptr;
+
+  RenderFrameHostImpl* rfhi = focused_frame->current_frame_host();
+  if (rfhi->GetRenderWidgetHost())
+    return rfhi->GetRenderWidgetHost()->GetView();
+  else if (rfhi->GetRenderViewHost())

[Charlie Reis, 2016/02/17 06:22:14]

nit: No else needed after return.

Also, this looks wrong according to the comment on GetRenderWidgetHost.  That
already returns the RVH's RWH for the main frame (making this branch
unnecessary), but it returns null for subframes that don't own their own widget
(which aren't handled here).

[kenrb, 2016/02/17 23:05:53]

I hadn't noticed this, but right. I think everything from line 1679 to the end
of the method can be replaced by
return focused_frame->current_frame_host()->GetView();

[EhsanK, 2016/02/18 05:48:01]

Yes this is the correct way. Thanks!

[EhsanK, 2016/02/18 05:48:01]

I guess using RFH::GetView() resolves all the issues.
Done.

+    return RenderWidgetHostImpl::From(rfhi->GetRenderViewHost()->GetWidget())
+        ->GetView();
+
+  NOTREACHED();
+  return nullptr;
+}
+
 void WebContentsImpl::EnterFullscreenMode(const GURL& origin) {
   // This method is being called to enter renderer-initiated fullscreen mode.
   // Make sure any existing fullscreen widget is shut down first.
   RenderWidgetHostView* const widget_view = GetFullscreenRenderWidgetHostView();
   if (widget_view) {
     RenderWidgetHostImpl::From(widget_view->GetRenderWidgetHost())
         ->ShutdownAndDestroyWidget(true);
   }
 
   if (delegate_)
@@ skipping 3067 matching lines @@
     const WebContentsObserver::MediaPlayerId& id) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, MediaStartedPlaying(id));
 }
 
 void WebContentsImpl::MediaStoppedPlaying(
     const WebContentsObserver::MediaPlayerId& id) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, MediaStoppedPlaying(id));
 }
 
 }  // namespace content