Browser Side Text Input State Tracking for OOPIF.

chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/stringprintf.h"
@@ skipping 486 matching lines @@
   void SetUpCommandLine(base::CommandLine* command_line) override {
     WebViewInteractiveTestBase::SetUpCommandLine(command_line);
 
     bool use_cross_process_frames_for_guests = GetParam();
     if (use_cross_process_frames_for_guests)
       command_line->AppendSwitch(switches::kUseCrossProcessFramesForGuests);
   }
 };
 
 class WebViewNewWindowInteractiveTest : public WebViewInteractiveTest {};
+class WebViewTextInputStateInteractiveTest : public WebViewInteractiveTest {};
 
 // The following class of tests do not work for OOPIF <webview>.
 // TODO(ekaramad): Make this tests work with OOPIF and replace the test classes
 // with WebViewInteractiveTest (see crbug.com/582562).
 class WebViewFocusInteractiveTest : public WebViewInteractiveTestBase {};
 class WebViewPopupInteractiveTest : public WebViewInteractiveTestBase {};
 class WebViewContextMenuInteractiveTest : public WebViewInteractiveTestBase {};
 class WebViewPointerLockInteractiveTest : public WebViewInteractiveTestBase {};
 class WebViewDragDropInteractiveTest : public WebViewInteractiveTestBase {};
 
 INSTANTIATE_TEST_CASE_P(WebViewInteractiveTests,
                         WebViewInteractiveTest,
                         testing::Bool());
 
 INSTANTIATE_TEST_CASE_P(WebViewInteractiveTests,
                         WebViewNewWindowInteractiveTest,
                         testing::Bool());
 
+INSTANTIATE_TEST_CASE_P(WebViewInteractiveTests,
+                        WebViewTextInputStateInteractiveTest,
+                        testing::Bool());

[lazyboy, 2016/04/06 02:39:53]

testing::Values(false), since all the tests in this test class
(WebViewTextInputStateInteractiveTest) is disabled under OOPIF, then you could
remove the early return on lines 1392, 1433 below.

Pull the TODO to fix this from below to here. And possibly refer to a bug.

[EhsanK, 2016/04/06 16:04:50]

Done.

+
 // ui_test_utils::SendMouseMoveSync doesn't seem to work on OS_MACOSX, and
 // likely won't work on many other platforms as well, so for now this test
 // is for Windows and Linux only. As of Sept 17th, 2013 this test is disabled
 // on Windows due to flakines, see http://crbug.com/293445.
 
 // Disabled on Linux Aura because pointer lock does not work on Linux Aura.
 // crbug.com/341876
 
 #if defined(OS_LINUX)
 // flaky http://crbug.com/412086
@@ skipping 804 matching lines @@
   // this time.
   for (size_t i = 0; i < 4; ++i)
     SendKeyPressToPlatformApp(ui::VKEY_TAB);
   ExtensionTestMessageListener webview_button_not_focused_listener(
       "WebViewInteractiveTest.WebViewButtonWasNotFocused", false);
   webview_button_not_focused_listener.set_failure_message(
       "WebViewInteractiveTest.WebViewButtonWasFocused");
   SendMessageToEmbedder("verify");
   EXPECT_TRUE(webview_button_not_focused_listener.WaitUntilSatisfied());
 }
+
+// A helper class which polls the text input state of the given WebContents.
+class TextInputStateHelper {

[lazyboy, 2016/04/06 02:39:54]

Move this class to a anonymous namespace and put it at the very beginning of
this file.

[EhsanK, 2016/04/06 16:04:50]

Done.

+ public:
+  using Predicate =
+      base::Callback<bool(const content::TextInputStateTestExport&)>;
+
+  static void WaitForDesiredState(content::WebContents* web_contents,
+                                  const Predicate& predicate) {
+    content::TextInputStateTestExport state =
+        content::TextInputStateTestExport::FromWebContents(web_contents);
+    while (!predicate.Run(state)) {
+      scoped_refptr<content::MessageLoopRunner> loop =
+          new content::MessageLoopRunner();
+      content::BrowserThread::PostDelayedTask(
+          content::BrowserThread::UI, FROM_HERE, loop->QuitClosure(),
+          base::TimeDelta::FromMilliseconds(1LL));

[lazyboy, 2016/04/06 02:39:53]

1ms is too agressive, I'd do ~100ms, put the value in a constant
kInputStateMonitorRetryInterval or sth.

[EhsanK, 2016/04/06 16:04:50]

Done.

+      loop->Run();
+      state = content::TextInputStateTestExport::FromWebContents(web_contents);
+    }
+  }
+
+  static bool IsStateOfGivenType(
+      ui::TextInputType type,
+      const content::TextInputStateTestExport& state) {
+    return type == state.type();
+  }
+
+  static bool HasGivenValue(const std::string& value,
+                            const content::TextInputStateTestExport& state) {
+    return value == state.value();
+  }
+};
+
+// TODO(ekaramad): Activate this test for OOPIF when input event routing for
+// OOPIF-<webview> is fixed.
+IN_PROC_BROWSER_TEST_P(WebViewTextInputStateInteractiveTest,
+                       TopLevelWebContentsTracksCorrectly) {
+  if (content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests())
+    return;
+
+  SetupTest("web_view/text_input_state",
+            "/extensions/platform_apps/web_view/text_input_state/guest.html");
+
+  auto press_tab_to_focus = [](WebViewTextInputStateInteractiveTest* test,
+                               const std::string& message) {
+    ExtensionTestMessageListener listener(message, false);
+    test->SendKeyPressToPlatformApp(ui::VKEY_TAB);
+    listener.WaitUntilSatisfied();
+  };
+
+  auto get_type_checker = [](ui::TextInputType target) {
+    return base::Bind(&TextInputStateHelper::IsStateOfGivenType, target);
+  };
+
+  // Press the tab key. The <input> in the embedder should get focused.
+  // Top level state type should be number.
+  press_tab_to_focus(this, "EMBEDDER-FOCUSED-1");
+  TextInputStateHelper::WaitForDesiredState(
+      embedder_web_contents(), get_type_checker(ui::TEXT_INPUT_TYPE_NUMBER));
+
+  // Press the tab key again and the <input> inside <webview> gets focused. The
+  // input type should text now.
+  press_tab_to_focus(this, "GUEST-FOCUSED");
+  TextInputStateHelper::WaitForDesiredState(
+      embedder_web_contents(), get_type_checker(ui::TEXT_INPUT_TYPE_TEXT));
+
+  // Press the tab key one more time to get back to embedder's second <input>.
+  // The value should be "last one".
+  press_tab_to_focus(this, "EMBEDDER-FOCUSED-2");
+  TextInputStateHelper::WaitForDesiredState(
+      embedder_web_contents(),
+      base::Bind(&TextInputStateHelper::HasGivenValue, "last one"));
+}
+
+// TODO(ekaramad): Activate this test for OOPIF when input event routing for
+// OOPIF-<webview> is fixed.
+IN_PROC_BROWSER_TEST_P(WebViewTextInputStateInteractiveTest,
+                       CrashingWebViewResetsState) {
+  if (content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests())
+    return;
+
+  SetupTest("web_view/text_input_state",
+            "/extensions/platform_apps/web_view/text_input_state/guest.html");
+
+  // Press tab key twice to end up in the <input> of the <webview>,
+  ExtensionTestMessageListener listener("GUEST-FOCUSED", false);
+  for (size_t i = 0; i < 2; ++i)
+    SendKeyPressToPlatformApp(ui::VKEY_TAB);
+
+  listener.WaitUntilSatisfied();
+
+  // Now wait for a text input state change.
+  TextInputStateHelper::WaitForDesiredState(
+      embedder_web_contents(),
+      base::Bind(&TextInputStateHelper::HasGivenValue, "guest"));
+
+  // Now crash the <webview>.
+  guest_web_contents()->GetRenderProcessHost()->Shutdown(false, 0);
+
+  // State should reset to none.
+  TextInputStateHelper::WaitForDesiredState(
+      embedder_web_contents(),
+      base::Bind(&TextInputStateHelper::IsStateOfGivenType,
+                 ui::TEXT_INPUT_TYPE_NONE));
+}