Browser Side Text Input State Tracking for OOPIF.

content/browser/frame_host/render_widget_host_view_child_frame.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
@@ skipping 178 matching lines @@
   // RenderWidgetHostViewChildFrame which do not get a SetIsLoading() call.
   if (BrowserPluginGuestMode::UseCrossProcessFramesForGuests() &&
       BrowserPluginGuest::IsGuest(
           static_cast<RenderViewHostImpl*>(RenderViewHost::From(host_)))) {
     return;
   }
 
   NOTREACHED();
 }
 
-void RenderWidgetHostViewChildFrame::TextInputStateChanged(
-    const ViewHostMsg_TextInputState_Params& params) {
-  // TODO(kenrb): Implement.
-}
-
 void RenderWidgetHostViewChildFrame::RenderProcessGone(
     base::TerminationStatus status,
     int error_code) {
   if (frame_connector_)
     frame_connector_->RenderProcessGone();
   Destroy();
 }
 
 void RenderWidgetHostViewChildFrame::Destroy() {
   // SurfaceIdNamespaces registered with RenderWidgetHostInputEventRouter
   // have already been cleared when RenderWidgetHostViewBase notified its
   // observers of our impending destruction.
   if (frame_connector_) {
     frame_connector_->set_view(NULL);
     frame_connector_ = NULL;
   }
 
   // We notify our observers about shutdown here since we are about to release
   // host_ and do not want any event calls coming from
   // RenderWidgetHostInputEventRouter afterwards.
   NotifyObserversAboutShutdown();
 
+  // If this view has an active text input, the RenderWidgetHostDelegate should
+  // be notified.
+  if (text_input_state()->type != ui::TEXT_INPUT_TYPE_NONE)
+    TextInputStateChanged(TextInputState());

[Charlie Reis, 2016/03/15 18:32:00]

Why are we passing in an empty one rather than text_input_state()?

[EhsanK, 2016/03/15 23:51:17]

This line will reset the WebContents knowledge of text input state, if it had
come from this RWHV. The WebContents currently holds a pointer the RWHV as well
as the last reported value of TextInputState. If this RWHV goes out of
existence, those information will be invalid and it will cause errors in IME
workings (also cursor stuff).

This line will hit when the renderer crashes.

However, as I see it now, it might be best to separate this task into another
method. I have done that in the new patch. Please let me know if it makes sense.

This new method is called NotifyHostDelegateAboutShutdown() and should be called
before host_->SetView(NULL). I think this method should also be called in
top-level RWHV, otherwise, the same issue might arise in cases with nested
WebContents.

[Charlie Reis, 2016/03/16 16:55:13]

I see-- I didn't notice that this was during Destroy before.  Yes, the new
approach makes sense.

[EhsanK, 2016/03/30 20:46:03]

Done.

+
   host_->SetView(NULL);
   host_ = NULL;
   base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
 }
 
 void RenderWidgetHostViewChildFrame::SetTooltipText(
     const base::string16& tooltip_text) {
 }
 
 void RenderWidgetHostViewChildFrame::SelectionChanged(
@@ skipping 343 matching lines @@
   if (surface_factory_ && !surface_id_.is_null())
     surface_factory_->Destroy(surface_id_);
   surface_id_ = cc::SurfaceId();
 }
 
 cc::SurfaceId RenderWidgetHostViewChildFrame::SurfaceIdForTesting() const {
   return surface_id_;
 };
 
 }  // namespace content