Browser Side Text Input State Tracking for OOPIF.

content/browser/site_per_process_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/site_per_process_browsertest.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 5514 matching lines @@
       new MainThreadFrameObserver(root_render_widget_host));
   observer->Wait();
 
   // Force the renderer to generate a new frame.
   EXPECT_TRUE(ExecuteScript(shell()->web_contents(),
                             "document.body.style.background = 'black'"));
 
   // Waits for the next frame.
   observer->Wait();
 }
+// This class observes the first change in the text input state
+// for a given RenderWidgetHostViewBase.
+class TextInputStateObserver {
+ public:
+  TextInputStateObserver(RenderWidgetHostViewBase* view)
+      : view_(view),
+        state_(*view->current_text_input_state()),
+        message_loop_runner_(nullptr) {}
+
+  // Hold and keep polling the |view_| until its text input state changes.
+  TextInputState WaitUntilStateChanges() {
+    while (!DidChangeState()) {
+      message_loop_runner_ = new MessageLoopRunner;
+      BrowserThread::ID current_thread_id;
+      EXPECT_TRUE(
+          BrowserThread::GetCurrentThreadIdentifier(&current_thread_id));
+      BrowserThread::PostDelayedTask(current_thread_id, FROM_HERE,
+                                     message_loop_runner_->QuitClosure(),
+                                     base::TimeDelta::FromMicroseconds(500));

[Charlie Reis, 2016/03/09 00:09:33]

Is there any way to avoid this polling?  It's generally not a good strategy to
use in tests.

If we need it, maybe we should use a similar pattern as other cases, like 
SurfaceHitTestReadyNotifier::WaitForSurfaceReady().

[EhsanK, 2016/03/14 19:58:08]

Done.

+      message_loop_runner_->Run();
+    }
+    return *view_->current_text_input_state();
+  }
+
+ private:
+  bool DidChangeState() {
+    TextInputState current = *view_->current_text_input_state();
+    return state_.type != current.type || state_.mode != current.mode ||
+           state_.value != current.value;
+  }
+  RenderWidgetHostViewBase* view_;
+  TextInputState state_;
+  scoped_refptr<MessageLoopRunner> message_loop_runner_;
+
+  DISALLOW_COPY_AND_ASSIGN(TextInputStateObserver);
+};
+
+// Verify that by moving the focus between different frames the top-level
+// RenderWidgetHostViewBase tracks the input state properly.
+IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, TextInputStateChanged) {
+  GURL main_page_url(embedded_test_server()->GetURL(
+      "a.com", "/textinput/page_with_input_field_and_iframe.html"));
+  NavigateToURL(shell(), main_page_url);
+  GURL cross_origin_url(embedded_test_server()->GetURL(
+      "b.com", "/textinput/page_with_input_field_and_iframe.html"));
+  FrameTreeNode* root = static_cast<WebContentsImpl*>(shell()->web_contents())
+                            ->GetFrameTree()
+                            ->root();
+  // Wait for the main frame to finish loading.
+  EXPECT_TRUE(WaitForRenderFrameReady(root->current_frame_host()));
+
+  // Navigate the child frame.
+  FrameTreeNode* child_frame_node = root->child_at(0);
+  NavigateFrameToURL(child_frame_node, cross_origin_url);
+
+  // Wait for the child frame to finish loading.
+  EXPECT_TRUE(WaitForRenderFrameReady(child_frame_node->current_frame_host()));
+
+  RenderWidgetHostImpl* root_rwh =
+      root->current_frame_host()->GetRenderWidgetHost();
+  RenderWidgetHostViewBase* root_rwhv = root_rwh->GetView();
+
+  EXPECT_EQ(root_rwhv->current_text_input_state()->type,
+            ui::TEXT_INPUT_TYPE_NONE);

[Charlie Reis, 2016/03/09 00:09:33]

nit: Reverse the parameters, since the contract is EXPECT_EQ(expected, actual). 
This matters for error messages.

(Same below.)

[EhsanK, 2016/03/14 19:58:08]

Done.

+  // Focus the root (main-frame). This would focus the text input field.

[Charlie Reis, 2016/03/09 00:09:33]

nit: Add blank line before.

[EhsanK, 2016/03/14 19:58:08]

Done.

+  TextInputStateObserver root_observer(root_rwhv);
+  SimulateMouseClick(root_rwh, 1, 1);
+  TextInputState new_state = root_observer.WaitUntilStateChanges();
+  EXPECT_EQ(new_state.type, ui::TEXT_INPUT_TYPE_TEXT);
+
+  // Now focus the child frame and read the text input state.
+  RenderWidgetHostImpl* child_rwh =
+      child_frame_node->current_frame_host()->GetRenderWidgetHost();
+  RenderWidgetHostViewBase* child_rwhv = child_rwh->GetView();
+  TextInputStateObserver child_observer(child_rwhv);
+  SimulateMouseClick(child_rwh, 1, 1);
+  new_state = child_observer.WaitUntilStateChanges();
+
+  EXPECT_EQ(new_state.type, ui::TEXT_INPUT_TYPE_TEXT);
+
+  // Finally, the top level view should see the child's view.
+  new_state = *root_rwhv->current_text_input_state();
+  EXPECT_EQ(new_state.type, ui::TEXT_INPUT_TYPE_TEXT);
+  EXPECT_EQ(new_state.value, cross_origin_url.spec());
+}
 
 // Test that a cross-origin iframe can be blocked by X-Frame-Options and CSP
 // frame-ancestors.
 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
                        CrossSiteIframeBlockedByXFrameOptionsOrCSP) {
   GURL main_url(embedded_test_server()->GetURL(
       "a.com", "/cross_site_iframe_factory.html?a(a)"));
   NavigateToURL(shell(), main_url);
 
   FrameTreeNode* root = static_cast<WebContentsImpl*>(shell()->web_contents())
@@ skipping 56 matching lines @@
     // affect future navigations for a frame. Verify this for the above
     // navigation.
     EXPECT_EQ(c_url.GetOrigin().spec(),
               root->child_at(0)->current_origin().Serialize() + "/");
     EXPECT_EQ(blink::WebSandboxFlags::None,
               root->child_at(0)->effective_sandbox_flags());
   }
 }
 
 }  // namespace content