Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: test/server/stream_test.dart

Issue 1652413002: Use StreamChannel. (Closed) Base URL: git@github.com:dart-lang/json_rpc_2.git@master
Patch Set: Code review changes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/peer_test.dart ('k') | test/server/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/server/stream_test.dart
diff --git a/test/server/stream_test.dart b/test/server/stream_test.dart
index 58c5e62ac0dc259ebd428f74862f66847903f00d..7be00011bbab969057a6c6c41b09c50648ea957e 100644
--- a/test/server/stream_test.dart
+++ b/test/server/stream_test.dart
@@ -4,17 +4,25 @@
import 'dart:async';
+import 'package:stream_channel/stream_channel.dart';
import 'package:test/test.dart';
+
import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
import 'utils.dart';
void main() {
+ var requestController;
+ var responseController;
+ var server;
+ setUp(() {
+ requestController = new StreamController();
+ responseController = new StreamController();
+ server = new json_rpc.Server.withoutJson(
+ new StreamChannel(requestController.stream, responseController.sink));
+ });
+
test(".withoutJson supports decoded stream and sink", () {
- var requestController = new StreamController();
- var responseController = new StreamController();
- var server = new json_rpc.Server.withoutJson(
- requestController.stream, responseController.sink);
server.listen();
server.registerMethod('foo', (params) {
@@ -36,11 +44,6 @@ void main() {
});
test(".listen returns when the controller is closed", () {
- var requestController = new StreamController();
- var responseController = new StreamController();
- var server = new json_rpc.Server(
- requestController.stream, responseController.sink);
-
var hasListenCompeted = false;
expect(server.listen().then((_) => hasListenCompeted = true), completes);
@@ -53,30 +56,19 @@ void main() {
});
test(".listen returns a stream error", () {
- var requestController = new StreamController();
- var responseController = new StreamController();
- var server = new json_rpc.Server(
- requestController.stream, responseController.sink);
-
expect(server.listen(), throwsA('oh no'));
requestController.addError('oh no');
});
test(".listen can't be called twice", () {
- var requestController = new StreamController();
- var responseController = new StreamController();
- var server = new json_rpc.Server(
- requestController.stream, responseController.sink);
server.listen();
expect(() => server.listen(), throwsStateError);
});
test(".close cancels the stream subscription and closes the sink", () {
- var requestController = new StreamController();
- var responseController = new StreamController();
- var server = new json_rpc.Server(
- requestController.stream, responseController.sink);
+ // Work around sdk#19095.
+ responseController.stream.listen(null);
expect(server.listen(), completes);
@@ -87,13 +79,4 @@ void main() {
expect(() => requestController.stream.listen((_) {}), throwsStateError);
expect(responseController.isClosed, isTrue);
});
-
- test(".close can't be called before .listen", () {
- var requestController = new StreamController();
- var responseController = new StreamController();
- var server = new json_rpc.Server(
- requestController.stream, responseController.sink);
-
- expect(() => server.close(), throwsStateError);
- });
}
« no previous file with comments | « test/peer_test.dart ('k') | test/server/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698