net/quic/quic_one_block_arena.h - Issue 1652383002: Deprecate FLAGS_quic_enable_arena_allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_one_block_arena.h

Issue 1652383002: Deprecate FLAGS_quic_enable_arena_allocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@112975578

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_one_block_arena.h

diff --git a/net/quic/quic_one_block_arena.h b/net/quic/quic_one_block_arena.h

index b4d65e2fe8f9ecf95838ce929a412973d6d4cbd0..6a2e6c894f3b8e32004a3e3b93b3134be6f576c4 100644

--- a/net/quic/quic_one_block_arena.h

+++ b/net/quic/quic_one_block_arena.h

@@ -59,9 +59,6 @@ QuicArenaScopedPtr<T> QuicOneBlockArena<ArenaSize>::New(Args&&... args) {

<< "Object is too large for the arena.";

static_assert(QUIC_ALIGN_OF(T) > 1,

"Objects added to the arena must be at least 2B aligned.");

- if (!FLAGS_quic_enable_arena_allocation) {

- return QuicArenaScopedPtr<T>(new T(std::forward<Args>(args)...));

- }

if (PREDICT_FALSE(offset_ > ArenaSize - AlignedSize<T>())) {

LOG(DFATAL) << "Ran out of space in QuicOneBlockArena at " << this

<< ", max size was " << ArenaSize << ", failing request was "

« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/quic/quic_one_block_arena_test.cc » ('j') | no next file with comments »