Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-creation.html

Issue 1652373004: MediaRecorder: add and wire read {video,audio}BitsPerSecond props (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reviewers@ comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-creation.html
diff --git a/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-creation.html b/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-creation.html
index f6e32d45869b669d624276c5f57bb03cf8cded81..bb1d03e4feba194bd1d1452137e934e4472a6f6d 100644
--- a/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-creation.html
+++ b/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-creation.html
@@ -19,6 +19,8 @@ function makeAsyncTest(constraints, verifyStream, message) {
assert_unreached('Exception while creating MediaRecorder: ' + e);
}
assert_equals(recorder.state, "inactive");
+ assert_equals(recorder.videoBitsPerSecond, 0);
philipj_slow 2016/02/03 03:31:05 That seems weird, why shouldn't this return the de
mcasas 2016/02/03 23:50:27 Because the bitrate, when left by JS as undefined,
philipj_slow 2016/02/04 03:03:10 Well, the encoder isn't really targeting a zero bi
+ assert_equals(recorder.audioBitsPerSecond, 0);
test.done();
});

Powered by Google App Engine
This is Rietveld 408576698