third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp - Issue 1652373004: MediaRecorder: add and wire read {video,audio}BitsPerSecond props

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

Issue 1652373004: MediaRecorder: add and wire read {video,audio}BitsPerSecond props (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h ('K') | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h ('k') | third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

index dcdf46fe4f1df3b28592634c2dbec822fc3d5de4..3592b591f54ad92adef4ad4d1ce94e69ab346487 100644

--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

@@ -153,12 +153,10 @@ MediaRecorder::MediaRecorder(ExecutionContext* context, MediaStream* stream, con

return;

}

- int32_t audioBitsPerSecond = 0;

- int32_t videoBitsPerSecond = 0;

- AllocateVideoAndAudioBitrates(exceptionState, context, options, stream, &audioBitsPerSecond, &videoBitsPerSecond);

+ AllocateVideoAndAudioBitrates(exceptionState, context, options, stream, &m_audioBitsPerSecond, &m_videoBitsPerSecond);

const ContentType contentType(m_mimeType);

- if (!m_recorderHandler->initialize(this, stream->descriptor(), contentType.type(), contentType.parameter("codecs"), audioBitsPerSecond, videoBitsPerSecond)) {

+ if (!m_recorderHandler->initialize(this, stream->descriptor(), contentType.type(), contentType.parameter("codecs"), m_audioBitsPerSecond, m_videoBitsPerSecond)) {

exceptionState.throwDOMException(NotSupportedError, "Failed to initialize native MediaRecorder the type provided (" + m_mimeType + ") is not supported.");

return;

}