MediaRecorder: add and wire read {video,audio}BitsPerSecond props

third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/mediarecorder/MediaRecorder.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "core/events/Event.h"
 #include "core/fileapi/Blob.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "modules/EventTargetModules.h"
 #include "modules/mediarecorder/BlobEvent.h"
 #include "platform/ContentType.h"
 #include "platform/NotImplemented.h"
 #include "platform/blob/BlobData.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebMediaStream.h"
+#include <algorithm>
 
 namespace blink {
 
 namespace {
 
 // Boundaries of Opus bitrate from https://www.opus-codec.org/.
 const int kSmallestPossibleOpusBitRate = 6000;
 const int kLargestAutoAllocatedOpusBitRate = 128000;
 
 // Smallest Vpx bitrate that can be requested.
@@ skipping 14 matching lines @@
     return String();
 }
 
 // Allocates the requested bit rates from |bitrateOptions| into the respective
 // |{audio,video}BitsPerSecond| (where a value of zero indicates Platform to use
 // whatever it sees fit). If |options.bitsPerSecond()| is specified, it
 // overrides any specific bitrate, and the UA is free to allocate as desired:
 // here a 90%/10% video/audio is used. In all cases where a value is explicited
 // or calculated, values are clamped in sane ranges.
 // This method throws NotSupportedError.
-void AllocateVideoAndAudioBitrates(ExceptionState& exceptionState, ExecutionContext* context, const MediaRecorderOptions& options, MediaStream* stream, int32_t* audioBitsPerSecond, int32_t* videoBitsPerSecond)
+void AllocateVideoAndAudioBitrates(ExceptionState& exceptionState, ExecutionContext* context, const MediaRecorderOptions& options, MediaStream* stream, int* audioBitsPerSecond, int* videoBitsPerSecond)
 {
-    // Throw if any value would overflow an int32_t.
-    // TODO(mcasas): This section would no be needed if the bit rates are signed, see https://github.com/w3c/mediacapture-record/issues/48.
-    const uint32_t kInt32MaxValueAsULong = std::numeric_limits<int32_t>::max();
-    if (options.bitsPerSecond() >= kInt32MaxValueAsULong) {
-        exceptionState.throwDOMException(NotSupportedError, "Overall bit rate too large " + String::number(options.bitsPerSecond()) + "bps)");
-        return;
-    }
-    if (options.bitsPerSecond() == 0) {
-        if (options.videoBitsPerSecond() >= kInt32MaxValueAsULong) {
-            exceptionState.throwDOMException(NotSupportedError, "Video bit rate too large " + String::number(options.videoBitsPerSecond()) + "bps)");
-            return;
-        }
-        if (options.audioBitsPerSecond() >= kInt32MaxValueAsULong) {
-            exceptionState.throwDOMException(NotSupportedError, "Audio bit rate too large " + String::number(options.audioBitsPerSecond()) + "bps)");
-            return;
-        }
-    }
+    // Clamp incoming values into a signed integer's range.
+    // TODO(mcasas): This section would no be needed if the bit rates are signed or double, see https://github.com/w3c/mediacapture-record/issues/48.
+    const unsigned kMaxIntAsUnsigned = std::numeric_limits<int>::max();
 
-    int32_t videoBps = options.videoBitsPerSecond();
-    int32_t audioBps = options.audioBitsPerSecond();
-    bool useVideo = stream->getVideoTracks().size() > 0;
-    bool useAudio = stream->getAudioTracks().size() > 0;
+    ASSERT(options.bitsPerSecond() >= 0);

[philipj_slow, 2016/02/05 07:48:49]

This ought to result in a tautological compare warning, but since the bots don't
complain I assume that warning is disabled. This chunk of code is assuming that
options.*PerSecond() are unsigned and not intended to be more generic, so I
would drop the always-true asserts.

[mcasas, 2016/02/06 00:26:25]

Done.

[philipj_slow, 2016/02/08 09:34:11]

You didn't remove it :)

+    ASSERT(options.bitsPerSecond() < kMaxIntAsUnsigned);
+    const int overallBps = std::min(options.bitsPerSecond(), kMaxIntAsUnsigned);
+
+    ASSERT(overallBps != 0 || options.videoBitsPerSecond() >= 0);

[philipj_slow, 2016/02/05 07:48:49]

If the trailing "||true" is dropped, note that this assert is also trivial to
fail, just call new MediaRecorder({ bitsPerSecond: 0})?

[mcasas, 2016/02/06 00:26:25]

These are basically ASSERT(if a then b) implemented 
with basic operators. In this case it means:

if (overallBps == 0) then (options.videoBitsPerSecond() must be X)

where X is: "non negative" or "smaller than the max".

I removed the first ASSERT, but cannot use
|options.hasBitsPerSecond()| since that would not return
true when the user has explicitly configured them to be 0.

Added a comment to clarify what I'm doing.

+    ASSERT(overallBps != 0 || options.videoBitsPerSecond() < kMaxIntAsUnsigned);
+    int videoBps = std::min(options.videoBitsPerSecond(), kMaxIntAsUnsigned);
+
+    ASSERT(overallBps != 0 || options.audioBitsPerSecond() >= 0);
+    ASSERT(overallBps != 0 || options.audioBitsPerSecond() < kMaxIntAsUnsigned);
+    int audioBps = std::min(options.audioBitsPerSecond(), kMaxIntAsUnsigned);
+
+    const bool useVideo = stream->getVideoTracks().size() > 0;
+    const bool useAudio = stream->getAudioTracks().size() > 0;
 
     if (useAudio) {
-        // |options.bitsPerSecond()| overrides the specific audio and video bit rates.
-        if (options.bitsPerSecond()) {
+        // |overallBps| overrides the specific audio and video bit rates.
+        if (overallBps) {
             if (useVideo)
-                audioBps = options.bitsPerSecond() / 10;
+                audioBps = overallBps / 10;
             else
-                audioBps = options.bitsPerSecond();
+                audioBps = overallBps;
         }
         // Limit audio bitrate values if set explicitly or calculated.
         if (audioBps) {
             if (audioBps > kLargestAutoAllocatedOpusBitRate) {
                 context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Clamping calculated audio bitrate (" + String::number(audioBps) + "bps) to the maximum (" + String::number(kLargestAutoAllocatedOpusBitRate) + "bps)"));
                 audioBps = kLargestAutoAllocatedOpusBitRate;
             }
 
             if (audioBps < kSmallestPossibleOpusBitRate) {
                 context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Clamping calculated audio bitrate (" + String::number(audioBps) + "bps) to the minimum (" + String::number(kSmallestPossibleOpusBitRate) + "bps)"));
                 audioBps = kSmallestPossibleOpusBitRate;
             }
         }
     } else {
         audioBps = 0;
     }
     if (useVideo) {
-        // Allocate the remaining overall |options.bitsPerSecond()|, if any, to video.
-        if (options.bitsPerSecond())
-            videoBps = options.bitsPerSecond() - audioBps;
-        // Clamp the video bit rate if the user has set explicitly the video bit rate or has used the overall bitrate.
-        if ((options.videoBitsPerSecond() > 0 || options.bitsPerSecond() > 0) && (videoBps < kSmallestPossibleVpxBitRate)) {
+        // Allocate the remaining |overallBps|, if any, to video.
+        if (overallBps)
+            videoBps = overallBps - audioBps;
+        // Clamp the video bit rate if the user has set it explicitly or has used the overall bitrate.
+        if ((options.videoBitsPerSecond() > 0 || overallBps > 0) && (videoBps < kSmallestPossibleVpxBitRate)) {
             context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Clamping calculated video bitrate (" + String::number(videoBps) + "bps) to the minimum (" + String::number(kSmallestPossibleVpxBitRate) + "bps)"));
             videoBps = kSmallestPossibleVpxBitRate;
         }
     } else {
         videoBps = 0;
     }
 
     *videoBitsPerSecond = videoBps;
     *audioBitsPerSecond = audioBps;
     return;
@@ skipping 17 matching lines @@
     return recorder;
 }
 
 MediaRecorder::MediaRecorder(ExecutionContext* context, MediaStream* stream, const MediaRecorderOptions& options, ExceptionState& exceptionState)
     : ActiveDOMObject(context)
     , m_stream(stream)
     , m_streamAmountOfTracks(stream->getTracks().size())
     , m_mimeType(options.mimeType())
     , m_stopped(true)
     , m_ignoreMutedMedia(true)
+    , m_audioBitsPerSecond(0)
+    , m_videoBitsPerSecond(0)
     , m_state(State::Inactive)
     , m_dispatchScheduledEventRunner(AsyncMethodRunner<MediaRecorder>::create(this, &MediaRecorder::dispatchScheduledEvent))
 {
     ASSERT(m_stream->getTracks().size());
 
     m_recorderHandler = adoptPtr(Platform::current()->createMediaRecorderHandler());
     ASSERT(m_recorderHandler);
 
     if (!m_recorderHandler) {
         exceptionState.throwDOMException(NotSupportedError, "No MediaRecorder handler can be created.");
         return;
     }
 
-    int32_t audioBitsPerSecond = 0;
-    int32_t videoBitsPerSecond = 0;
-    AllocateVideoAndAudioBitrates(exceptionState, context, options, stream, &audioBitsPerSecond, &videoBitsPerSecond);
+    AllocateVideoAndAudioBitrates(exceptionState, context, options, stream, &m_audioBitsPerSecond, &m_videoBitsPerSecond);
 
     const ContentType contentType(m_mimeType);
-    if (!m_recorderHandler->initialize(this, stream->descriptor(), contentType.type(), contentType.parameter("codecs"), audioBitsPerSecond, videoBitsPerSecond)) {
+    if (!m_recorderHandler->initialize(this, stream->descriptor(), contentType.type(), contentType.parameter("codecs"), m_audioBitsPerSecond, m_videoBitsPerSecond)) {
         exceptionState.throwDOMException(NotSupportedError, "Failed to initialize native MediaRecorder the type provided (" + m_mimeType + ") is not supported.");
         return;
     }
     m_stopped = false;
 }
 
 String MediaRecorder::state() const
 {
     return stateToString(m_state);
 }
@@ skipping 181 matching lines @@
 DEFINE_TRACE(MediaRecorder)
 {
     visitor->trace(m_stream);
     visitor->trace(m_dispatchScheduledEventRunner);
     visitor->trace(m_scheduledEvents);
     RefCountedGarbageCollectedEventTargetWithInlineData<MediaRecorder>::trace(visitor);
     ActiveDOMObject::trace(visitor);
 }
 
 } // namespace blink