Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1652353003: Initial round of cleanups now all events go through StartRequest. (Closed)

Created:
4 years, 10 months ago by Marijn Kruisselbrink
Modified:
4 years, 9 months ago
Reviewers:
nhiroki
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor-fetch-event
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initial round of cleanups now all events go through StartRequest. The RequestType enum is no longer needed, and AddRequest can get merged into StartRequest. BUG=570820 Committed: https://crrev.com/72feb1c098834b8734b7caba1de75331a9d321a8 Cr-Commit-Position: refs/heads/master@{#378537}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -131 lines) Patch
M content/browser/service_worker/service_worker_version.h View 1 2 chunks +0 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 8 chunks +50 lines, -105 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Marijn Kruisselbrink
Not sure why I let this linger for so long. There are probably more cleanups ...
4 years, 9 months ago (2016-03-01 00:27:26 UTC) #3
nhiroki
lgtm
4 years, 9 months ago (2016-03-01 09:21:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652353003/20001
4 years, 9 months ago (2016-03-01 17:36:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 19:53:31 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/72feb1c098834b8734b7caba1de75331a9d321a8 Cr-Commit-Position: refs/heads/master@{#378537}
4 years, 9 months ago (2016-03-01 19:55:19 UTC) #9
Dmitry Titov
4 years, 9 months ago (2016-03-03 02:04:53 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1758163002/ by dimich@chromium.org.

The reason for reverting is: Speculative revert to see if it affects memory
leaks started yesterday: http://crbug.com/591596

Will reland if it is innocent..

Powered by Google App Engine
This is Rietveld 408576698