Replace WebDocument::focusedNode to focusedElement

Replace WebDocument::focusedNode to  focusedElement

WebDocument::focusedNode is a deprecated Api, move chromium to new api focusedElement.

BUG=258763
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253703

[maheshkk, 2014-02-25 00:01:36]

Please take a look.

[Ben Goodger (Google), 2014-02-25 18:13:15]

-me,+jam

[jam, 2014-02-26 17:48:53]

lgtm

https://codereview.chromium.org/165233003/diff/100001/components/autofill/con...
File components/autofill/content/renderer/page_click_tracker.cc (right):

https://codereview.chromium.org/165233003/diff/100001/components/autofill/con...
components/autofill/content/renderer/page_click_tracker.cc:49: blink::WebNode
focused_node = newly_clicked_node.document().focusedElement();
nit: rename to focused_element?

https://codereview.chromium.org/165233003/diff/100001/content/public/renderer...
File content/public/renderer/render_view.h (right):

https://codereview.chromium.org/165233003/diff/100001/content/public/renderer...
content/public/renderer/render_view.h:79: // Gets the focused element. If no
such node exists then the element will Null.
nit: 80 chars

[maheshkk, 2014-02-26 19:29:00]

On 2014/02/26 17:48:53, jam wrote:
> lgtm
> 
>
https://codereview.chromium.org/165233003/diff/100001/components/autofill/con...
> File components/autofill/content/renderer/page_click_tracker.cc (right):
> 
>
https://codereview.chromium.org/165233003/diff/100001/components/autofill/con...
> components/autofill/content/renderer/page_click_tracker.cc:49: blink::WebNode
> focused_node = newly_clicked_node.document().focusedElement();
> nit: rename to focused_element?
> 

Done.

>
https://codereview.chromium.org/165233003/diff/100001/content/public/renderer...
> File content/public/renderer/render_view.h (right):
> 
>
https://codereview.chromium.org/165233003/diff/100001/content/public/renderer...
> content/public/renderer/render_view.h:79: // Gets the focused element. If no
> such node exists then the element will Null.
> nit: 80 chars

Done.

Thank you!

[maheshkk, 2014-02-26 19:29:07]

The CQ bit was checked by mahesh.kk@samsung.com

[commit-bot: I haz the power, 2014-02-26 19:31:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/165233003/120001

[commit-bot: I haz the power, 2014-02-26 20:03:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-26 20:04:00]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[maheshkk, 2014-02-26 20:27:34]

Missing LGTM from an OWNER for these files:
    components/autofill/content/renderer/page_click_tracker.cc

jochen, joi could you please  take a look?

[Ilya Sherman, 2014-02-26 21:28:53]

Autofill changes LGTM w/ nit addressed:

https://codereview.chromium.org/165233003/diff/120001/components/autofill/con...
File components/autofill/content/renderer/page_click_tracker.cc (right):

https://codereview.chromium.org/165233003/diff/120001/components/autofill/con...
components/autofill/content/renderer/page_click_tracker.cc:138:
last_node_clicked_ = node;
nit: node -> element?  Please consider updating all instances of "node" to
"element" throughout this file.

[maheshkk, 2014-02-26 21:46:57]

On 2014/02/26 21:28:53, Ilya Sherman wrote:
> Autofill changes LGTM w/ nit addressed:
> 
>
https://codereview.chromium.org/165233003/diff/120001/components/autofill/con...
> File components/autofill/content/renderer/page_click_tracker.cc (right):
> 
>
https://codereview.chromium.org/165233003/diff/120001/components/autofill/con...
> components/autofill/content/renderer/page_click_tracker.cc:138:
> last_node_clicked_ = node;
> nit: node -> element?  Please consider updating all instances of "node" to
> "element" throughout this file.

Thanks for the review Ilya, As per the bug in this CL, specs assume only
elements can be focused and not nodes. 
However, in the above file, events code like WebDomEvent.target() returns
WebNode and _last_node_clicked member variable is expected to store WebNode. 

I would be happy to look at changing the remaining code to use WebElement
wherever possible throughout chromium code and I propose to do that using
different CL. How does that sound?

[Ilya Sherman, 2014-02-26 22:17:13]

On 2014/02/26 21:46:57, maheshkk wrote:
> On 2014/02/26 21:28:53, Ilya Sherman wrote:
> > Autofill changes LGTM w/ nit addressed:
> > 
> >
>
https://codereview.chromium.org/165233003/diff/120001/components/autofill/con...
> > File components/autofill/content/renderer/page_click_tracker.cc (right):
> > 
> >
>
https://codereview.chromium.org/165233003/diff/120001/components/autofill/con...
> > components/autofill/content/renderer/page_click_tracker.cc:138:
> > last_node_clicked_ = node;
> > nit: node -> element?  Please consider updating all instances of "node" to
> > "element" throughout this file.
> 
> Thanks for the review Ilya, As per the bug in this CL, specs assume only
> elements can be focused and not nodes. 
> However, in the above file, events code like WebDomEvent.target() returns
> WebNode and _last_node_clicked member variable is expected to store WebNode. 
> 
> I would be happy to look at changing the remaining code to use WebElement
> wherever possible throughout chromium code and I propose to do that using
> different CL. How does that sound?

Ok by me.  Thanks.

[maheshkk, 2014-02-26 22:18:47]

The CQ bit was checked by mahesh.kk@samsung.com

[commit-bot: I haz the power, 2014-02-26 22:21:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/165233003/120001

[commit-bot: I haz the power, 2014-02-26 23:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-26 23:55:08]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Ilya Sherman, 2014-02-26 23:56:43]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-02-27 00:10:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/165233003/120001

[commit-bot: I haz the power, 2014-02-27 03:33:19]

Change committed as 253703