Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1652293002: Fix 2D canvas content loss while page is hidden (Closed)

Created:
4 years, 10 months ago by Justin Novosad
Modified:
4 years, 10 months ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 2D canvas content loss while page is hidden Relanding https://codereview.chromium.org/1618283006 with an additional fix and unit tests to cover the crash from crbug.com/580949 BUG=578963 R=senorblanco@chromium.org Committed: https://crrev.com/6b9c2b5d5fa1451e1e5a11a627534f5d3859d77b Cr-Commit-Position: refs/heads/master@{#373095}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 16 chunks +102 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1618863002 Patch 1

Messages

Total messages: 7 (2 generated)
Justin Novosad
PTAL
4 years, 10 months ago (2016-02-01 21:07:01 UTC) #1
Stephen White
LGTM
4 years, 10 months ago (2016-02-02 00:17:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652293002/20001
4 years, 10 months ago (2016-02-02 20:54:16 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 00:18:59 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 00:20:17 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6b9c2b5d5fa1451e1e5a11a627534f5d3859d77b
Cr-Commit-Position: refs/heads/master@{#373095}

Powered by Google App Engine
This is Rietveld 408576698