Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1652243002: Revert of Test262 roll to the state as of 2016-19-1 (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Test262 roll to the state as of 2016-19-1 (patchset #6 id:100001 of https://codereview.chromium.org/1637103002/ ) Reason for revert: [Sheriff] Breaks tsan and msan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/7590 https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/6572 Original issue's description: > Test262 roll to the state as of 2016-19-1 > > R=adamk > > Committed: https://crrev.com/bce83db2e25e1260468f8f33a5c52e63d08372b3 > Cr-Commit-Position: refs/heads/master@{#33645} TBR=adamk@chromium.org,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -54 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 8 chunks +30 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Achenbach
Created Revert of Test262 roll to the state as of 2016-19-1
4 years, 10 months ago (2016-02-01 19:51:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652243002/1
4 years, 10 months ago (2016-02-01 19:51:29 UTC) #2
commit-bot: I haz the power
Failed to commit the patch.
4 years, 10 months ago (2016-02-01 19:51:43 UTC) #4
adamk
I'm working on skipping this test on msan and tsan (it was already skipped on ...
4 years, 10 months ago (2016-02-01 19:52:35 UTC) #5
Michael Achenbach
On 2016/02/01 19:51:43, commit-bot: I haz the power wrote: > Failed to commit the patch. ...
4 years, 10 months ago (2016-02-01 19:53:56 UTC) #6
adamk
4 years, 10 months ago (2016-02-01 21:34:36 UTC) #7
Also skipped on tsan now. this can be closed.

Powered by Google App Engine
This is Rietveld 408576698