Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: chrome/browser/value_store/testing_value_store.cc

Issue 165223003: Add a Restore() method to ValueStore and make StorageAPI use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/value_store/testing_value_store.cc
diff --git a/chrome/browser/value_store/testing_value_store.cc b/chrome/browser/value_store/testing_value_store.cc
index c8d177c55147d5f26d0d2ef15853853dbc36cc4d..4f83e8cb4e15ab59fddea84d0d84d03e182cc438 100644
--- a/chrome/browser/value_store/testing_value_store.cc
+++ b/chrome/browser/value_store/testing_value_store.cc
@@ -124,6 +124,29 @@ ValueStore::WriteResult TestingValueStore::Clear() {
return Remove(keys);
}
+bool TestingValueStore::Restore() {
+ ReadResult result = Get();
+ std::string previous_key;
+ while (result->IsCorrupted()) {
+ if (!result->error().key.get() || *result->error().key == previous_key ||
+ !RestoreKey(*result->error().key)) {
+ Clear();
+ result = Get();
+ break;
+ }
+ previous_key = *result->error().key;
+ result = Get();
+ }
+ return !result->IsCorrupted();
+}
+
+bool TestingValueStore::RestoreKey(const std::string& key) {
+ ReadResult result = Get(key);
+ if (result->IsCorrupted())
+ Remove(key);
+ return !Get(key)->IsCorrupted();
+}
not at google - send to devlin 2014/02/19 21:25:29 yeah I think this isn't really called for yet.
Devlin 2014/02/19 23:12:28 Done.
+
scoped_ptr<ValueStore::Error> TestingValueStore::TestingError() {
return make_scoped_ptr(new ValueStore::Error(
error_code_, kGenericErrorMessage, scoped_ptr<std::string>()));

Powered by Google App Engine
This is Rietveld 408576698