Add a Restore() method to ValueStore and make StorageAPI use it

chrome/browser/value_store/testing_value_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/value_store/testing_value_store.h"
 
 #include "base/logging.h"
 
 namespace {
 
@@ skipping 106 matching lines @@
 
 ValueStore::WriteResult TestingValueStore::Clear() {
   std::vector<std::string> keys;
   for (base::DictionaryValue::Iterator it(storage_);
        !it.IsAtEnd(); it.Advance()) {
     keys.push_back(it.key());
   }
   return Remove(keys);
 }
 
+bool TestingValueStore::Restore() {
+  ReadResult result = Get();
+  std::string previous_key;
+  while (result->HasError() && result->error().code == CORRUPTION) {

[not at google - send to devlin, 2014/02/14 19:35:56]

How does this class get corrupted storage?

I'm surprised how complex these methods are. I would have thought they're
basically no-ops.

[Devlin, 2014/02/18 23:55:22]

Yeah...this might be overkill.  My basic thought was that I wanted the
TestingValueStore to behave as much as possible like a real value store, so that
if we wanted to instigate corruption for testing reasons, it would still behave
like the other stores.  Not worth it?

[not at google - send to devlin, 2014/02/19 21:25:29]

Not worth it.

[Devlin, 2014/02/19 23:12:28]

Done.

+    if (!result->error().key.get() || *result->error().key == previous_key ||
+        !RestoreKey(*result->error().key)) {
+      Clear();
+      result = Get();
+      break;
+    }
+    previous_key = *result->error().key;
+    result = Get();
+  }
+  return result->HasError() && result->error().code == CORRUPTION;
+}
+
+bool TestingValueStore::RestoreKey(const std::string& key) {
+  ReadResult result = Get(key);
+  if (result->HasError() && result->error().code == CORRUPTION)
+    Remove(key);
+  return Get(key)->HasError();
+}
+
 scoped_ptr<ValueStore::Error> TestingValueStore::TestingError() {
   return make_scoped_ptr(new ValueStore::Error(
       error_code_, kGenericErrorMessage, scoped_ptr<std::string>()));
 }