Add a Restore() method to ValueStore and make StorageAPI use it

chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/sequenced_task_runner.h"
-#include "chrome/browser/extensions/api/storage/settings_backend.h"
+#include "chrome/browser/extensions/api/storage/local_storage_backend.h"
 #include "chrome/browser/extensions/api/storage/settings_frontend.h"
 #include "chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.h"
+#include "chrome/browser/extensions/api/storage/sync_storage_backend.h"
 #include "chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.h"
 #include "chrome/browser/sync/glue/sync_start_util.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/permissions/api_permission.h"
 
 using content::BrowserThread;
 
 namespace extensions {
@@ skipping 16 matching lines @@
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&SyncOrLocalValueStoreCache::InitOnFileThread,
                  base::Unretained(this),
                  factory, quota, observers, profile_path));
 }
 
 SyncOrLocalValueStoreCache::~SyncOrLocalValueStoreCache() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 }
 
-SettingsBackend* SyncOrLocalValueStoreCache::GetAppBackend() const {
+syncer::SyncableService* SyncOrLocalValueStoreCache::GetSyncableService(
+    syncer::ModelType type) const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
-  DCHECK(app_backend_.get());
-  return app_backend_.get();
-}
-
-SettingsBackend* SyncOrLocalValueStoreCache::GetExtensionBackend() const {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
-  DCHECK(extension_backend_.get());
-  return extension_backend_.get();
+  switch (type) {
+    case syncer::APP_SETTINGS:
+      DCHECK(app_backend_.get());

[not at google - send to devlin, 2014/02/14 19:35:56]

all this DCHECK'ing of backends looks weird. Let's just have an |initialized_|
boolean.

[Devlin, 2014/02/18 23:55:22]

Done.

+      return app_backend_->GetAsSyncableService();
+    case syncer::EXTENSION_SETTINGS:
+      DCHECK(extension_backend_.get());
+      return extension_backend_->GetAsSyncableService();
+    default:
+      NOTREACHED();
+      return NULL;
+  }
 }
 
 void SyncOrLocalValueStoreCache::RunWithValueStoreForExtension(
     const StorageCallback& callback,
     scoped_refptr<const Extension> extension) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   DCHECK(app_backend_.get());
   DCHECK(extension_backend_.get());
   SettingsBackend* backend =
       extension->is_app() ? app_backend_.get() : extension_backend_.get();
@@ skipping 24 matching lines @@
 }
 
 void SyncOrLocalValueStoreCache::InitOnFileThread(
     const scoped_refptr<SettingsStorageFactory>& factory,
     const SettingsStorageQuotaEnforcer::Limits& quota,
     const scoped_refptr<SettingsObserverList>& observers,
     const base::FilePath& profile_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   DCHECK(!app_backend_.get());
   DCHECK(!extension_backend_.get());
   const bool local = settings_namespace_ == settings_namespace::LOCAL;

[not at google - send to devlin, 2014/02/14 19:35:56]

use switch

[Devlin, 2014/02/18 23:55:22]

Done.

-  const base::FilePath app_path = profile_path.AppendASCII(
-      local ? extensions::kLocalAppSettingsDirectoryName
-            : extensions::kSyncAppSettingsDirectoryName);
-  const base::FilePath extension_path = profile_path.AppendASCII(
-      local ? extensions::kLocalExtensionSettingsDirectoryName
-            : extensions::kSyncExtensionSettingsDirectoryName);
-  app_backend_.reset(new SettingsBackend(
-      factory, app_path, syncer::APP_SETTINGS,
-      sync_start_util::GetFlareForSyncableService(profile_path),
-      quota, observers));
-  extension_backend_.reset(new SettingsBackend(
-      factory, extension_path, syncer::EXTENSION_SETTINGS,
-      sync_start_util::GetFlareForSyncableService(profile_path),
-      quota, observers));
+  if (local) {
+    app_backend_.reset(new LocalStorageBackend(
+        factory,
+        profile_path.AppendASCII(kLocalAppSettingsDirectoryName),
+        quota));
+    extension_backend_.reset(new LocalStorageBackend(
+        factory,
+        profile_path.AppendASCII(kLocalExtensionSettingsDirectoryName),
+        quota));
+  } else {
+    app_backend_.reset(new SyncStorageBackend(
+        factory,
+        profile_path.AppendASCII(kSyncAppSettingsDirectoryName),
+        quota,
+        observers,
+        syncer::APP_SETTINGS,
+        sync_start_util::GetFlareForSyncableService(profile_path)));
+    extension_backend_.reset(new SyncStorageBackend(
+        factory,
+        profile_path.AppendASCII(kSyncExtensionSettingsDirectoryName),
+        quota,
+        observers,
+        syncer::EXTENSION_SETTINGS,
+        sync_start_util::GetFlareForSyncableService(profile_path)));
+  }
 }
 
 }  // namespace extensions