Issue 165223: Enable skia asserts. They were disabled some time ago due to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165223: Enable skia asserts. They were disabled some time ago due to... (Closed)

Created:
11 years, 4 months ago by Stephen White

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable skia asserts. They were disabled some time ago due to http://crbug.com/6372, which has since been fixed. Some existing asserts were failing due to having been untested, and were fixed in this CL. BUG=http://crbug.com/6373. TEST=unit tests, layout tests, etc do not assert Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22916

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -24 lines)			Patch
M	skia/config/SkUserConfig.h	View	1 2 3	1 chunk	+0 lines, -14 lines	0 comments	Download
M	skia/ext/SkFontHost_fontconfig.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/image_operations_unittest.cc	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	skia/ext/vector_platform_device_linux.cc	View	2 3	4 chunks	+3 lines, -4 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	2 3	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

11 years, 4 months ago (2009-08-10 03:40:03 UTC) #2

LGTM, other than:

http://codereview.chromium.org/165223/diff/1004/19
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/165223/diff/1004/19#newcode2864
Line 2864: BUG18896 WIN : LayoutTests/svg/carto.net/window.svg = FAIL
Probably should be WIN LINUX DEBUG.

Expand Messages | Collapse Messages