chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java - Issue 1652163002: Refactor Clank cast code to use MediaNotificationManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java

Issue 1652163002: Refactor Clank cast code to use MediaNotificationManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@MediaUi

Patch Set: Remove redundant Android resources (fix lint.py errors). Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/remote/LockScreenTransportControl.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java

index 5ebad07693050449fdd4fb767a23ec24f536341b..e81079457349fbceaf6711e3e3e73b42a87eb242 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java

@@ -31,7 +31,7 @@ import org.chromium.third_party.android.media.MediaController;

/**

* The activity that's opened by clicking the video flinging (casting) notification.

- * TODO(cimamoglu): Refactor to merge some common logic with {@link TransportControl}.

+ * TODO(cimamoglu): Refactor to merge some common logic with {@link CastNotificationControl}.

whywhat 2016/02/01 20:54:14 I doubt Cihat will ever fix this, maybe change the

aberent 2016/02/02 14:31:11 Done, assuming we don't get rid of this completely

public class ExpandedControllerActivity

extends FragmentActivity implements MediaRouteController.UiListener {