Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 165213006: [DevTools] Issue zoom from DevToolsWindow instead of browser commands. (Closed)

Created:
6 years, 10 months ago by dgozman
Modified:
6 years, 10 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[DevTools] Issue zoom from DevToolsWindow instead of browser commands. This helps to avoid confusion when wrench menu zoom affects DevTools instead of the page. BUG=343816 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dgozman
Could you please take a look? Unfortunately, previous approach was confusing, since UI elements are ...
6 years, 10 months ago (2014-02-14 13:21:14 UTC) #1
vsevik
lgtm
6 years, 10 months ago (2014-02-14 13:34:39 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-14 14:19:16 UTC) #3
jochen (gone - plz use gerrit)
lgtm lgtm
6 years, 10 months ago (2014-02-14 14:19:17 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 10 months ago (2014-02-14 14:45:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/165213006/1
6 years, 10 months ago (2014-02-14 14:45:53 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 15:12:46 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50335
6 years, 10 months ago (2014-02-14 15:12:47 UTC) #8
Tom Sepez
lgtm
6 years, 10 months ago (2014-02-14 19:12:05 UTC) #9
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 10 months ago (2014-02-14 20:17:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/165213006/1
6 years, 10 months ago (2014-02-14 20:20:15 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 00:15:01 UTC) #12
Message was sent while issue was closed.
Change committed as 251448

Powered by Google App Engine
This is Rietveld 408576698