Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165213005: Avoid using transparency layer for fancy borders. (Closed)

Created:
6 years, 10 months ago by alokp
Modified:
6 years, 10 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., ernstm, bsalomon_chromium, reed2
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid using transparency layer for fancy borders. We paint transparent borders with radius on an offscreen layer. This is unnecessary and expensive especially for gpu rasterization. This patch simply removes the save-restore layer steps. The border edges are now painted slightly differently. It is not wrong - just different. A few borders have color values that are off by one integral value, which was unexpected. This is a skia bug - skbug.com/2211. BUG=343188 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167942

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : added test expectations #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : expanded test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -19 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +37 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 3 2 chunks +3 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 2 3 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
alokp
6 years, 10 months ago (2014-02-25 01:15:03 UTC) #1
Stephen Chennney
lgtm
6 years, 10 months ago (2014-02-25 17:13:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/165213005/50001
6 years, 10 months ago (2014-02-25 17:13:58 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 19:08:32 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=19930
6 years, 10 months ago (2014-02-25 19:08:32 UTC) #5
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 10 months ago (2014-02-26 09:01:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/165213005/70001
6 years, 10 months ago (2014-02-26 09:02:05 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 10:58:48 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20063
6 years, 10 months ago (2014-02-26 10:58:48 UTC) #9
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 10 months ago (2014-02-26 19:20:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/165213005/110001
6 years, 10 months ago (2014-02-26 19:21:16 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 23:32:30 UTC) #12
Message was sent while issue was closed. 
Change committed as 167942

Powered by Google App Engine
This is Rietveld 408576698