Prepare for per-webview virtual time

Prepare for per-webview virtual time

This patch removes the initial global virtual time implementation (including the flag)
and prepares for per-webview virtual time.  A follow on patch will wire this
up in blink: https://codereview.chromium.org/1646583002/

BUG=546953
Committed: https://crrev.com/d4b2c47b8488ca4f943735c663bcb45c42765cdc
Cr-Commit-Position: refs/heads/master@{#373032}

[alex clarke (OOO till 29th), 2016-02-01 15:32:54]

Description was changed from

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time and prepares for
per-webview virtual time.

BUG=
==========

to

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time and prepares for
per-webview virtual time.

BUG=546953
==========

[alex clarke (OOO till 29th), 2016-02-01 15:33:29]

Description was changed from

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time and prepares for
per-webview virtual time.

BUG=546953
==========

to

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time and prepares for
per-webview virtual time.  A follow on patch will wire this up in blink:
https://codereview.chromium.org/1646583002/

BUG=546953
==========

[alex clarke (OOO till 29th), 2016-02-01 15:34:05]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2016-02-01 15:34:46]

Description was changed from

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time and prepares for
per-webview virtual time.  A follow on patch will wire this up in blink:
https://codereview.chromium.org/1646583002/

BUG=546953
==========

to

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time (including the flag)
and prepares for per-webview virtual time.  A follow on patch will wire this
up in blink: https://codereview.chromium.org/1646583002/

BUG=546953
==========

[commit-bot: I haz the power, 2016-02-01 15:35:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/1

[alex clarke (OOO till 29th), 2016-02-01 15:41:48]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2016-02-01 15:42:07]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[alex clarke (OOO till 29th), 2016-02-01 15:42:08]

Here's a slightly cut down version Sami.

[commit-bot: I haz the power, 2016-02-01 15:42:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/20001

[alex clarke (OOO till 29th), 2016-02-01 16:11:11]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-01 16:11:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/40001

[commit-bot: I haz the power, 2016-02-01 17:04:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 17:04:43]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Sami, 2016-02-01 17:05:39]

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
File components/scheduler/base/task_queue_manager.cc (right):

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
components/scheduler/base/task_queue_manager.cc:279:
scoped_refptr<internal::TaskQueueImpl> prev_executing_task_queue =
Let's go back to the raw pointer and add a comment.

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
components/scheduler/base/task_queue_manager.cc:285: // Detect if the
TaskQueueManager just got deleted.  If this happens we must
Move to line 283.

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
File components/scheduler/base/task_queue_manager.h (right):

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
components/scheduler/base/task_queue_manager.h:129: internal::TaskQueueImpl*
currently_executing_task_queue() const {
Forgot to make this use the non-internal interface?

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/re...
File components/scheduler/renderer/web_frame_scheduler_impl.cc (right):

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/re...
components/scheduler/renderer/web_frame_scheduler_impl.cc:107: if
(timer_task_queue_.get()) {
nit: IIRC you don't need the .get() in these conditions.

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/re...
File components/scheduler/renderer/web_view_scheduler_impl.h (right):

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/re...
components/scheduler/renderer/web_view_scheduler_impl.h:45: void
useVirtualTime();
enableVirtualTime()

[alex clarke (OOO till 29th), 2016-02-01 17:49:28]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2016-02-01 17:50:10]

PTAL

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
File components/scheduler/base/task_queue_manager.cc (right):

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
components/scheduler/base/task_queue_manager.cc:279:
scoped_refptr<internal::TaskQueueImpl> prev_executing_task_queue =
On 2016/02/01 17:05:39, Sami wrote:
> Let's go back to the raw pointer and add a comment.

Done.

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
components/scheduler/base/task_queue_manager.cc:285: // Detect if the
TaskQueueManager just got deleted.  If this happens we must
On 2016/02/01 17:05:39, Sami wrote:
> Move to line 283.

Done.

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
File components/scheduler/base/task_queue_manager.h (right):

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/ba...
components/scheduler/base/task_queue_manager.h:129: internal::TaskQueueImpl*
currently_executing_task_queue() const {
On 2016/02/01 17:05:39, Sami wrote:
> Forgot to make this use the non-internal interface?

Done.

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/re...
File components/scheduler/renderer/web_frame_scheduler_impl.cc (right):

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/re...
components/scheduler/renderer/web_frame_scheduler_impl.cc:107: if
(timer_task_queue_.get()) {
On 2016/02/01 17:05:39, Sami wrote:
> nit: IIRC you don't need the .get() in these conditions.

Done.

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/re...
File components/scheduler/renderer/web_view_scheduler_impl.h (right):

https://codereview.chromium.org/1652083002/diff/40001/components/scheduler/re...
components/scheduler/renderer/web_view_scheduler_impl.h:45: void
useVirtualTime();
On 2016/02/01 17:05:39, Sami wrote:
> enableVirtualTime()

Done.

[commit-bot: I haz the power, 2016-02-01 17:50:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/60001

[alex clarke (OOO till 29th), 2016-02-01 18:07:17]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-01 18:07:32]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alex clarke (OOO till 29th), 2016-02-01 18:08:15]

Patchset #5 (id:80001) has been deleted

[alex clarke (OOO till 29th), 2016-02-01 18:08:45]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-01 18:13:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/100001

[Sami, 2016-02-01 18:22:36]

https://codereview.chromium.org/1652083002/diff/100001/components/scheduler/r...
File components/scheduler/renderer/web_frame_scheduler_impl.cc (right):

https://codereview.chromium.org/1652083002/diff/100001/components/scheduler/r...
components/scheduler/renderer/web_frame_scheduler_impl.cc:94:
(parent_web_view_scheduler_ &&
Doesn't the DCHECK make this redundant?

https://codereview.chromium.org/1652083002/diff/100001/components/scheduler/r...
File components/scheduler/renderer/web_view_scheduler_impl.h (right):

https://codereview.chromium.org/1652083002/diff/100001/components/scheduler/r...
components/scheduler/renderer/web_view_scheduler_impl.h:45: void
useVirtualTime();
Forgot to rename to enableVirtualTime?

[alex clarke (OOO till 29th), 2016-02-01 18:25:53]

https://codereview.chromium.org/1652083002/diff/100001/components/scheduler/r...
File components/scheduler/renderer/web_frame_scheduler_impl.cc (right):

https://codereview.chromium.org/1652083002/diff/100001/components/scheduler/r...
components/scheduler/renderer/web_frame_scheduler_impl.cc:94:
(parent_web_view_scheduler_ &&
On 2016/02/01 18:22:36, Sami wrote:
> Doesn't the DCHECK make this redundant?

Done.

https://codereview.chromium.org/1652083002/diff/100001/components/scheduler/r...
File components/scheduler/renderer/web_view_scheduler_impl.h (right):

https://codereview.chromium.org/1652083002/diff/100001/components/scheduler/r...
components/scheduler/renderer/web_view_scheduler_impl.h:45: void
useVirtualTime();
On 2016/02/01 18:22:36, Sami wrote:
> Forgot to rename to enableVirtualTime?

Done.

[alex clarke (OOO till 29th), 2016-02-01 18:26:01]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[Sami, 2016-02-01 18:27:32]

Thanks, lgtm.

[commit-bot: I haz the power, 2016-02-01 18:28:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/120001

[commit-bot: I haz the power, 2016-02-01 19:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 19:10:56]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alex clarke (OOO till 29th), 2016-02-01 20:40:49]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-01 20:42:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/140001

[commit-bot: I haz the power, 2016-02-01 20:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 20:54:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[alex clarke (OOO till 29th), 2016-02-01 22:01:46]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2016-02-01 22:01:56]

Patchset #7 (id:140001) has been deleted

[alex clarke (OOO till 29th), 2016-02-01 22:02:07]

Patchset #6 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-02-01 22:04:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/160001

[alex clarke (OOO till 29th), 2016-02-01 22:27:39]

alexclarke@chromium.org changed reviewers:
+ jochen@chromium.org

[alex clarke (OOO till 29th), 2016-02-01 22:27:39]

+jochen@ for OWNERS review

[alex clarke (OOO till 29th), 2016-02-01 22:28:08]

Description was changed from

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time (including the flag)
and prepares for per-webview virtual time.  A follow on patch will wire this
up in blink: https://codereview.chromium.org/1646583002/

BUG=546953
==========

to

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time implementation (including the
flag)
and prepares for per-webview virtual time.  A follow on patch will wire this
up in blink: https://codereview.chromium.org/1646583002/

BUG=546953
==========

[commit-bot: I haz the power, 2016-02-01 23:12:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 23:12:21]

Dry run: This issue passed the CQ dry run.

[alex clarke (OOO till 29th), 2016-02-02 18:10:02]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2016-02-02 18:10:41]

alexclarke@chromium.org changed reviewers:
+ sievers@chromium.org
- jochen@chromium.org

[commit-bot: I haz the power, 2016-02-02 18:12:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/180001

[alex clarke (OOO till 29th), 2016-02-02 18:12:45]

+sievers@ could you please do an OWNERS review? Looks like Jochen@ is busy :)

[no sievers, 2016-02-02 18:36:16]

On 2016/02/02 18:12:45, alexclarke1 wrote:
> +sievers@ could you please do an OWNERS review? Looks like Jochen@ is busy :)

lgtm

[commit-bot: I haz the power, 2016-02-02 19:17:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 19:17:43]

Dry run: This issue passed the CQ dry run.

[alex clarke (OOO till 29th), 2016-02-02 20:37:03]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-02-02 20:37:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1652083002/#ps180001
(title: "Rebased")

[alex clarke (OOO till 29th), 2016-02-02 20:37:20]

Thanks all!

[commit-bot: I haz the power, 2016-02-02 20:43:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652083002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652083002/180001

[commit-bot: I haz the power, 2016-02-02 20:55:16]

Description was changed from

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time implementation (including the
flag)
and prepares for per-webview virtual time.  A follow on patch will wire this
up in blink: https://codereview.chromium.org/1646583002/

BUG=546953
==========

to

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time implementation (including the
flag)
and prepares for per-webview virtual time.  A follow on patch will wire this
up in blink: https://codereview.chromium.org/1646583002/

BUG=546953
==========

[commit-bot: I haz the power, 2016-02-02 20:55:17]

Committed patchset #7 (id:180001)

[commit-bot: I haz the power, 2016-02-02 20:56:17]

Description was changed from

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time implementation (including the
flag)
and prepares for per-webview virtual time.  A follow on patch will wire this
up in blink: https://codereview.chromium.org/1646583002/

BUG=546953
==========

to

==========
Prepare for per-webview virtual time

This patch removes the initial global virtual time implementation (including the
flag)
and prepares for per-webview virtual time.  A follow on patch will wire this
up in blink: https://codereview.chromium.org/1646583002/

BUG=546953

Committed: https://crrev.com/d4b2c47b8488ca4f943735c663bcb45c42765cdc
Cr-Commit-Position: refs/heads/master@{#373032}
==========

[commit-bot: I haz the power, 2016-02-02 20:56:18]

Patchset 7 (id:??) landed as
https://crrev.com/d4b2c47b8488ca4f943735c663bcb45c42765cdc
Cr-Commit-Position: refs/heads/master@{#373032}