include/config/SkUserConfig.h - Issue 1652053004: Add Histogram Macros to Skia

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: include/config/SkUserConfig.h

Issue 1652053004: Add Histogram Macros to Skia (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1	1

2 /*	2 /*

3 * Copyright 2006 The Android Open Source Project	3 * Copyright 2006 The Android Open Source Project

4 *	4 *

5 * Use of this source code is governed by a BSD-style license that can be	5 * Use of this source code is governed by a BSD-style license that can be

6 * found in the LICENSE file.	6 * found in the LICENSE file.

7 */	7 */

8	8

9	9

10 #ifndef SkUserConfig_DEFINED	10 #ifndef SkUserConfig_DEFINED

(...skipping 135 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
146	146

147 /* The PDF generation code uses Path Ops to handle complex clipping paths,	147 /* The PDF generation code uses Path Ops to handle complex clipping paths,

148 * but at this time, Path Ops is not release ready yet. So, the code is	148 * but at this time, Path Ops is not release ready yet. So, the code is

149 * hidden behind this #define guard. If you are feeling adventurous and	149 * hidden behind this #define guard. If you are feeling adventurous and

150 * want the latest and greatest PDF generation code, uncomment the #define.	150 * want the latest and greatest PDF generation code, uncomment the #define.

151 * When Path Ops is release ready, the define guards and this user config	151 * When Path Ops is release ready, the define guards and this user config

152 * define should be removed entirely.	152 * define should be removed entirely.

153 */	153 */

154 //#define SK_PDF_USE_PATHOPS_CLIPPING	154 //#define SK_PDF_USE_PATHOPS_CLIPPING

155	155

	156 /* Skia makes use of several histogram logging macros to trace the frequency

	157 * of certain events. By default, Skia provides no-op versions of these

	158 * macros in SkHistogramLogging.h. If a consumer has a histogram/metric

	159 * collection backend, it may provide a custom header with their own

	160 * definitions of these macros.

	161 */

	162 //#define SK_HISTOGRAM_LOGGING_CUSTOM_SETUP_HEADER
	bsalomon 2016/02/01 21:18:08 I believe Chrome already uses a custom SkUseConfig I believe Chrome already uses a custom SkUseConfig file. Perhaps they could override the macros there and Skia could set the defaults in SkPostConfig.h? ericrk 2016/02/01 21:58:33 hmmm... yeah, Chrome has an SkUserConfig file, tha Show quoted text On 2016/02/01 21:18:08, bsalomon wrote: > I believe Chrome already uses a custom SkUseConfig file. Perhaps they could > override the macros there and Skia could set the defaults in SkPostConfig.h? hmmm... yeah, Chrome has an SkUserConfig file, that's where I was putting the SK_HISTOGRAM_LOGGING_CUSTOM_SETUP_HEADER define... I can put the macros there directly, but that ends up pulling more #includes into SkUserConfig, forcing every file in Skia to pull in the histogram headers for chrome. This approach overrides the values in a specific include file, so only those files that make use of the histogram macros need to pay the cost of the include... not sure if it really matters though, and I'm happy with either option - let me know what you think.
	163

156 #endif	164 #endif

OLD	NEW

« no previous file with comments | « no previous file | include/core/SkHistogramLogging.h » ('j') | no next file with comments »