Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1652023002: [arm][arm64] Minor improvements to MathMaxMin. (Closed)

Created:
4 years, 10 months ago by jbramley
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm][arm64] Minor improvements to MathMaxMin. BUG= Committed: https://crrev.com/7c8e32cfd8c9d8a9263d597abd0a6c53cd3a51c5 Cr-Commit-Position: refs/heads/master@{#33666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M src/arm/builtins-arm.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 3 chunks +25 lines, -38 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 10 months ago (2016-02-01 14:00:26 UTC) #2
Benedikt Meurer
Nice, thanks. LGTM.
4 years, 10 months ago (2016-02-01 18:18:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652023002/1
4 years, 10 months ago (2016-02-02 09:39:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 10:03:09 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 10:04:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7c8e32cfd8c9d8a9263d597abd0a6c53cd3a51c5
Cr-Commit-Position: refs/heads/master@{#33666}

Powered by Google App Engine
This is Rietveld 408576698