Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1652013002: [turbofan] Properly call %TraceExit on explicit return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index b236775154bf59a1962cfcfea71a4a8e9f48a0f9..5e88c86b6a7589a725094828e682d134c88d888b 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1203,6 +1203,9 @@ void AstGraphBuilder::VisitBreakStatement(BreakStatement* stmt) {
void AstGraphBuilder::VisitReturnStatement(ReturnStatement* stmt) {
VisitForValue(stmt->expression());
Node* result = environment()->Pop();
+ if (FLAG_trace) {
+ NewNode(javascript()->CallRuntime(Runtime::kTraceExit), result);
Michael Starzinger 2016/02/01 18:33:16 This needs to go into AstGraphBuilder::BuildReturn
Benedikt Meurer 2016/02/02 05:01:41 Done.
+ }
execution_control()->ReturnValue(result);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698