[turbofan] Properly call %TraceExit on explicit return.

[turbofan] Properly call %TraceExit on explicit return.

So far TurboFan only calls %TraceExit for the implicit
return of undefined, when the function contains no explicit
return statement. To make --trace useful, we also need to
call %TraceExit for ReturnStatement.

R=mstarzinger@chromium.org

Committed: https://crrev.com/329c1e5397322df0cd18ec91fbeab02c9c14024b
Cr-Commit-Position: refs/heads/master@{#33659}

[Benedikt Meurer, 2016-02-01 18:16:26]

Hey Michi,

Simple fix.
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2016-02-01 18:33:16]

https://codereview.chromium.org/1652013002/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1652013002/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:615: // TODO(mstarzinger): Only traces
implicit return.
Once the below comments about AstGraphBuilder::BuildReturn is addressed, this
explicit tracing code can be remove. It is covered by the call to BuildReturn
then.

https://codereview.chromium.org/1652013002/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:1207:
NewNode(javascript()->CallRuntime(Runtime::kTraceExit), result);
This needs to go into AstGraphBuilder::BuildReturn, otherwise it is being
executed before the finally block.

[Benedikt Meurer, 2016-02-02 05:01:41]

Comments address. Thanks.

https://codereview.chromium.org/1652013002/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1652013002/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:615: // TODO(mstarzinger): Only traces
implicit return.
On 2016/02/01 18:33:16, Michael Starzinger wrote:
> Once the below comments about AstGraphBuilder::BuildReturn is addressed, this
> explicit tracing code can be remove. It is covered by the call to BuildReturn
> then.

Done.

https://codereview.chromium.org/1652013002/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:1207:
NewNode(javascript()->CallRuntime(Runtime::kTraceExit), result);
On 2016/02/01 18:33:16, Michael Starzinger wrote:
> This needs to go into AstGraphBuilder::BuildReturn, otherwise it is being
> executed before the finally block.

Done.

[Benedikt Meurer, 2016-02-02 05:01:55]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-02 05:02:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652013002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652013002/20001

[commit-bot: I haz the power, 2016-02-02 05:29:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 05:29:39]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-02-02 09:03:26]

LGTM.

[Michael Starzinger, 2016-02-02 09:03:38]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-02-02 09:07:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652013002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652013002/20001

[commit-bot: I haz the power, 2016-02-02 09:11:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-02 09:12:39]

Description was changed from

==========
[turbofan] Properly call %TraceExit on explicit return.

So far TurboFan only calls %TraceExit for the implicit
return of undefined, when the function contains no explicit
return statement. To make --trace useful, we also need to
call %TraceExit for ReturnStatement.

R=mstarzinger@chromium.org
==========

to

==========
[turbofan] Properly call %TraceExit on explicit return.

So far TurboFan only calls %TraceExit for the implicit
return of undefined, when the function contains no explicit
return statement. To make --trace useful, we also need to
call %TraceExit for ReturnStatement.

R=mstarzinger@chromium.org

Committed: https://crrev.com/329c1e5397322df0cd18ec91fbeab02c9c14024b
Cr-Commit-Position: refs/heads/master@{#33659}
==========

[commit-bot: I haz the power, 2016-02-02 09:12:40]

Patchset 2 (id:??) landed as
https://crrev.com/329c1e5397322df0cd18ec91fbeab02c9c14024b
Cr-Commit-Position: refs/heads/master@{#33659}