Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1652003002: [test] Make missing files result in a proper test runner error. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Make missing files result in a proper test runner error. BUG= Committed: https://crrev.com/cd803b154737cbdfddbc7805f612dae4bac94ed4 Cr-Commit-Position: refs/heads/master@{#33684}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Demonstrate the problem. #

Patch Set 4 : Fix #

Patch Set 5 : Remove problem demonstration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/testrunner/local/pool.py View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652003002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652003002/100001
4 years, 10 months ago (2016-02-02 13:37:34 UTC) #3
Michael Achenbach
PTAL. Patch 3 demonstrates the problem. The builds are green despite missing files. Patch 4 ...
4 years, 10 months ago (2016-02-02 13:38:38 UTC) #5
Jakob Kummerow
"Internal error in a worker process" isn't a very helpful message, but since this is ...
4 years, 10 months ago (2016-02-02 13:42:56 UTC) #6
Michael Achenbach
On 2016/02/02 13:42:56, Jakob wrote: > "Internal error in a worker process" isn't a very ...
4 years, 10 months ago (2016-02-02 13:47:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652003002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652003002/100001
4 years, 10 months ago (2016-02-02 13:52:51 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 10 months ago (2016-02-02 13:58:41 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 13:59:17 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cd803b154737cbdfddbc7805f612dae4bac94ed4
Cr-Commit-Position: refs/heads/master@{#33684}

Powered by Google App Engine
This is Rietveld 408576698