Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 165200: Merge 22261 - Add defensive code in pickle to preclude realloc of shared head... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

Merge 22261 - Add defensive code in pickle to preclude realloc of shared header_ memory. Since I was able to (some how) generate a problem with header_ being double freed (perhaps, because it was shared in some way??), this change adds several lines of defensive coding. The current assignment operator appears very dangerous, as it allowed Resize to be called when the header_ was not owned by the instance (it was readonly). I haven't found a path to cause a problem, but we may as well be defensive. BUG=17027 BUG=17088 r=CPU Review URL: http://codereview.chromium.org/160490 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
MM base/pickle.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 4 months ago (2009-08-08 01:07:36 UTC) #1
jim.roskind
11 years, 4 months ago (2009-08-08 01:19:03 UTC) #2
LGTM (this is what I ment to LGTM... the other was the orginal patch)

Powered by Google App Engine
This is Rietveld 408576698