Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1651993002: [interpreter] Clear pending message object on handler entry. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Enable test. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index b730fa63ebe15a0ff2f637a3da14b19dda0cc968..11a0c548aa933d0097c5e09b95c5959d950a0340 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -4266,20 +4266,24 @@ TEST(TryCatch) {
{"try { return 1; } catch(e) { return 2; }",
5 * kPointerSize,
1,
- 27,
+ 36,
{
- B(LdaSmi8), U8(1), //
- B(Return), //
- B(Star), R(3), //
- B(LdaConstant), U8(0), //
- B(Star), R(2), //
- B(Ldar), R(closure), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(2), U8(3), //
- B(PushContext), R(0), //
- B(LdaSmi8), U8(2), //
- B(PopContext), R(0), //
- B(Return), //
+ B(LdaSmi8), U8(1), //
+ B(Return), //
+ B(Star), R(3), //
+ B(LdaConstant), U8(0), //
+ B(Star), R(2), //
+ B(Ldar), R(closure), //
+ B(Star), R(4), //
+ B(CallRuntime), U16(Runtime::kPushCatchContext), R(2), U8(3), //
+ B(Star), R(1), //
+ B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
+ /* */ R(0), U8(0), //
+ B(Ldar), R(1), //
+ B(PushContext), R(0), //
+ B(LdaSmi8), U8(2), //
+ B(PopContext), R(0), //
+ B(Return), //
// TODO(mstarzinger): Potential optimization, elide next bytes.
B(LdaUndefined), //
B(Return), //
@@ -4291,39 +4295,47 @@ TEST(TryCatch) {
{"var a; try { a = 1 } catch(e1) {}; try { a = 2 } catch(e2) { a = 3 }",
6 * kPointerSize,
1,
- 56,
+ 74,
{
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Jump), U8(21), //
- B(Star), R(4), //
- B(LdaConstant), U8(0), //
- B(Star), R(3), //
- B(Ldar), R(closure), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(3), U8(3), //
- B(PushContext), R(1), //
- B(PopContext), R(1), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(Jump), U8(25), //
- B(Star), R(4), //
- B(LdaConstant), U8(1), //
- B(Star), R(3), //
- B(Ldar), R(closure), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(3), U8(3), //
- B(PushContext), R(1), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(PopContext), R(1), //
- B(LdaUndefined), //
- B(Return), //
+ B(LdaSmi8), U8(1), //
+ B(Star), R(0), //
+ B(Jump), U8(30), //
+ B(Star), R(4), //
+ B(LdaConstant), U8(0), //
+ B(Star), R(3), //
+ B(Ldar), R(closure), //
+ B(Star), R(5), //
+ B(CallRuntime), U16(Runtime::kPushCatchContext), R(3), U8(3), //
+ B(Star), R(2), //
+ B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
+ /* */ R(0), U8(0), //
+ B(Ldar), R(2), //
+ B(PushContext), R(1), //
+ B(PopContext), R(1), //
+ B(LdaSmi8), U8(2), //
+ B(Star), R(0), //
+ B(Jump), U8(34), //
+ B(Star), R(4), //
+ B(LdaConstant), U8(1), //
+ B(Star), R(3), //
+ B(Ldar), R(closure), //
+ B(Star), R(5), //
+ B(CallRuntime), U16(Runtime::kPushCatchContext), R(3), U8(3), //
+ B(Star), R(2), //
+ B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
+ /* */ R(0), U8(0), //
+ B(Ldar), R(2), //
+ B(PushContext), R(1), //
+ B(LdaSmi8), U8(3), //
+ B(Star), R(0), //
+ B(PopContext), R(1), //
+ B(LdaUndefined), //
+ B(Return), //
},
2,
{"e1", "e2"},
2,
- {{0, 4, 6}, {25, 29, 31}}},
+ {{0, 4, 6}, {34, 38, 40}}},
};
for (size_t i = 0; i < arraysize(snippets); i++) {
@@ -4344,28 +4356,30 @@ TEST(TryFinally) {
{"var a = 1; try { a = 2; } finally { a = 3; }",
4 * kPointerSize,
1,
- 35,
+ 40,
{
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(LdaSmi8), U8(-1), //
- B(Star), R(1), //
- B(Jump), U8(7), //
- B(Star), R(2), //
- B(LdaZero), //
- B(Star), R(1), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(LdaZero), //
- B(TestEqualStrict), R(1), //
- B(JumpIfTrue), U8(4), //
- B(Jump), U8(5), //
- B(Ldar), R(2), //
- B(ReThrow), //
- B(LdaUndefined), //
- B(Return), //
+ B(LdaSmi8), U8(1), //
+ B(Star), R(0), //
+ B(LdaSmi8), U8(2), //
+ B(Star), R(0), //
+ B(LdaSmi8), U8(-1), //
+ B(Star), R(1), //
+ B(Jump), U8(7), //
+ B(Star), R(2), //
+ B(LdaZero), //
+ B(Star), R(1), //
+ B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
+ /* */ R(0), U8(0), //
+ B(LdaSmi8), U8(3), //
+ B(Star), R(0), //
+ B(LdaZero), //
+ B(TestEqualStrict), R(1), //
+ B(JumpIfTrue), U8(4), //
+ B(Jump), U8(5), //
+ B(Ldar), R(2), //
+ B(ReThrow), //
+ B(LdaUndefined), //
+ B(Return), //
},
0,
{},
@@ -4374,96 +4388,112 @@ TEST(TryFinally) {
{"var a = 1; try { a = 2; } catch(e) { a = 20 } finally { a = 3; }",
9 * kPointerSize,
1,
- 60,
+ 74,
{
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(Jump), U8(25), //
- B(Star), R(7), //
- B(LdaConstant), U8(0), //
- B(Star), R(6), //
- B(Ldar), R(closure), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(6), U8(3), //
- B(PushContext), R(1), //
- B(LdaSmi8), U8(20), //
- B(Star), R(0), //
- B(PopContext), R(1), //
- B(LdaSmi8), U8(-1), //
- B(Star), R(2), //
- B(Jump), U8(7), //
- B(Star), R(3), //
- B(LdaZero), //
- B(Star), R(2), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(LdaZero), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(4), //
- B(Jump), U8(5), //
- B(Ldar), R(3), //
- B(ReThrow), //
- B(LdaUndefined), //
- B(Return), //
+ B(LdaSmi8), U8(1), //
+ B(Star), R(0), //
+ B(LdaSmi8), U8(2), //
+ B(Star), R(0), //
+ B(Jump), U8(34), //
+ B(Star), R(7), //
+ B(LdaConstant), U8(0), //
+ B(Star), R(6), //
+ B(Ldar), R(closure), //
+ B(Star), R(8), //
+ B(CallRuntime), U16(Runtime::kPushCatchContext), R(6), U8(3), //
+ B(Star), R(5), //
+ B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
+ /* */ R(0), U8(0), //
+ B(Ldar), R(5), //
+ B(PushContext), R(1), //
+ B(LdaSmi8), U8(20), //
+ B(Star), R(0), //
+ B(PopContext), R(1), //
+ B(LdaSmi8), U8(-1), //
+ B(Star), R(2), //
+ B(Jump), U8(7), //
+ B(Star), R(3), //
+ B(LdaZero), //
+ B(Star), R(2), //
+ B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
+ /* */ R(0), U8(0), //
+ B(LdaSmi8), U8(3), //
+ B(Star), R(0), //
+ B(LdaZero), //
+ B(TestEqualStrict), R(2), //
+ B(JumpIfTrue), U8(4), //
+ B(Jump), U8(5), //
+ B(Ldar), R(3), //
+ B(ReThrow), //
+ B(LdaUndefined), //
+ B(Return), //
},
1,
{"e"},
2,
- {{4, 33, 39}, {4, 8, 10}}},
+ {{4, 42, 48}, {4, 8, 10}}},
{"var a; try {"
" try { a = 1 } catch(e) { a = 2 }"
"} catch(e) { a = 20 } finally { a = 3; }",
10 * kPointerSize,
1,
- 81,
+ 104,
{
- B(LdaSmi8), U8(1), //
- B(Star), R(0), //
- B(Jump), U8(25), //
- B(Star), R(8), //
- B(LdaConstant), U8(0), //
- B(Star), R(7), //
- B(Ldar), R(closure), //
- B(Star), R(9), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(7), U8(3), //
- B(PushContext), R(1), //
- B(LdaSmi8), U8(2), //
- B(Star), R(0), //
- B(PopContext), R(1), //
- B(Jump), U8(25), //
- B(Star), R(7), //
- B(LdaConstant), U8(0), //
- B(Star), R(6), //
- B(Ldar), R(closure), //
- B(Star), R(8), //
- B(CallRuntime), U16(Runtime::kPushCatchContext), R(6), U8(3), //
- B(PushContext), R(1), //
- B(LdaSmi8), U8(20), //
- B(Star), R(0), //
- B(PopContext), R(1), //
- B(LdaSmi8), U8(-1), //
- B(Star), R(2), //
- B(Jump), U8(7), //
- B(Star), R(3), //
- B(LdaZero), //
- B(Star), R(2), //
- B(LdaSmi8), U8(3), //
- B(Star), R(0), //
- B(LdaZero), //
- B(TestEqualStrict), R(2), //
- B(JumpIfTrue), U8(4), //
- B(Jump), U8(5), //
- B(Ldar), R(3), //
- B(ReThrow), //
- B(LdaUndefined), //
- B(Return), //
+ B(LdaSmi8), U8(1), //
+ B(Star), R(0), //
+ B(Jump), U8(34), //
+ B(Star), R(8), //
+ B(LdaConstant), U8(0), //
+ B(Star), R(7), //
+ B(Ldar), R(closure), //
+ B(Star), R(9), //
+ B(CallRuntime), U16(Runtime::kPushCatchContext), R(7), U8(3), //
+ B(Star), R(6), //
+ B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
+ /* */ R(0), U8(0), //
rmcilroy 2016/02/01 14:21:46 Nice hack for git cl format - I'll need to remembe
+ B(Ldar), R(6), //
+ B(PushContext), R(1), //
+ B(LdaSmi8), U8(2), //
+ B(Star), R(0), //
+ B(PopContext), R(1), //
+ B(Jump), U8(34), //
+ B(Star), R(7), //
+ B(LdaConstant), U8(0), //
+ B(Star), R(6), //
+ B(Ldar), R(closure), //
+ B(Star), R(8), //
+ B(CallRuntime), U16(Runtime::kPushCatchContext), R(6), U8(3), //
+ B(Star), R(5), //
+ B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
+ /* */ R(0), U8(0), //
+ B(Ldar), R(5), //
+ B(PushContext), R(1), //
+ B(LdaSmi8), U8(20), //
+ B(Star), R(0), //
+ B(PopContext), R(1), //
+ B(LdaSmi8), U8(-1), //
+ B(Star), R(2), //
+ B(Jump), U8(7), //
+ B(Star), R(3), //
+ B(LdaZero), //
+ B(Star), R(2), //
+ B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), //
+ /* */ R(0), U8(0), //
+ B(LdaSmi8), U8(3), //
+ B(Star), R(0), //
+ B(LdaZero), //
+ B(TestEqualStrict), R(2), //
+ B(JumpIfTrue), U8(4), //
+ B(Jump), U8(5), //
+ B(Ldar), R(3), //
+ B(ReThrow), //
+ B(LdaUndefined), //
+ B(Return), //
},
1,
{"e"},
3,
- {{0, 54, 60}, {0, 29, 31}, {0, 4, 6}}},
+ {{0, 72, 78}, {0, 38, 40}, {0, 4, 6}}},
};
for (size_t i = 0; i < arraysize(snippets); i++) {
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698