Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 1651973002: Revert of Auto-rebaseline for r372040 (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
nainar, wkorman
CC:
chromium-reviews, blink-reviews, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Auto-rebaseline for r372040 (patchset #1 id:1 of https://codereview.chromium.org/1651953003/ ) Reason for revert: The rebaseline didn't work as expected. fast/backgrounds/background-clip-text-composited.html started failing after this CL. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/60207 Original issue's description: > Auto-rebaseline for r372040 > > https://chromium.googlesource.com/chromium/src/+/7bec93241 > > BUG=498588 > TBR=nainar@chromium.org > > Committed: https://crrev.com/65f9b3462bdc684f6c68c9ac5b2497e03c14f9de > Cr-Commit-Position: refs/heads/master@{#372637} TBR=nainar@chromium.org,wkorman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498588 Committed: https://crrev.com/431942cb2f5e8e4e678348ae68ad00d67ff3ff03 Cr-Commit-Position: refs/heads/master@{#372645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
haraken
Created Revert of Auto-rebaseline for r372040
4 years, 10 months ago (2016-02-01 11:53:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651973002/1
4 years, 10 months ago (2016-02-01 11:54:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 11:55:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/431942cb2f5e8e4e678348ae68ad00d67ff3ff03 Cr-Commit-Position: refs/heads/master@{#372645}
4 years, 10 months ago (2016-02-01 11:57:19 UTC) #6
Timothy Loh
On 2016/02/01 11:57:19, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 10 months ago (2016-02-02 06:03:05 UTC) #7
haraken
4 years, 10 months ago (2016-02-02 06:04:26 UTC) #9
Message was sent while issue was closed.
On 2016/02/02 06:03:05, Timothy Loh wrote:
> On 2016/02/01 11:57:19, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/431942cb2f5e8e4e678348ae68ad00d67ff3ff03
> > Cr-Commit-Position: refs/heads/master@{#372645}
> 
> The test seems to be fine after a second rebaseline. Do you know if this is a
> known issue with the rebaseline bot or this is indicative of a flaky test? The
> flakiness dashboard doesn't show any flakiness.

I don't know but I guess this would be a bug of the rebaseline bot.

Powered by Google App Engine
This is Rietveld 408576698