Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1651933003: Removed few unused methods from ContentViewCore and CVRV (Closed)

Created:
4 years, 10 months ago by AKV
Modified:
4 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed few unused methods from ContentViewCore and CVRV This change takes care of removing few unused methods from ContentViewCore and ContentViewRenderView classes. BUG= Committed: https://crrev.com/41c14ef4fd99617ef6c8095255975866c70366a4 Cr-Commit-Position: refs/heads/master@{#372913}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed the review comments. #

Patch Set 3 : Removed CVRV::SetNeedsComposite() as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -56 lines) Patch
M content/browser/android/content_view_core_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/android/content_view_render_view.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/android/content_view_render_view.cc View 1 2 2 chunks +1 line, -15 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 1 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
AKV
PTAL!
4 years, 10 months ago (2016-02-01 18:26:11 UTC) #2
Ted C
lgtm https://codereview.chromium.org/1651933003/diff/1/content/browser/android/content_view_render_view.h File content/browser/android/content_view_render_view.h (left): https://codereview.chromium.org/1651933003/diff/1/content/browser/android/content_view_render_view.h#oldcode33 content/browser/android/content_view_render_view.h:33: void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj); I would ...
4 years, 10 months ago (2016-02-01 21:51:00 UTC) #3
AKV
https://codereview.chromium.org/1651933003/diff/1/content/browser/android/content_view_render_view.h File content/browser/android/content_view_render_view.h (left): https://codereview.chromium.org/1651933003/diff/1/content/browser/android/content_view_render_view.h#oldcode33 content/browser/android/content_view_render_view.h:33: void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj); On 2016/02/01 21:51:00, ...
4 years, 10 months ago (2016-02-02 06:02:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651933003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651933003/40001
4 years, 10 months ago (2016-02-02 07:37:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-02 08:41:02 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 08:42:43 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/41c14ef4fd99617ef6c8095255975866c70366a4
Cr-Commit-Position: refs/heads/master@{#372913}

Powered by Google App Engine
This is Rietveld 408576698