Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 1651933002: Report error on JS-interop operator [] and []= methods. (Closed)

Created:
4 years, 10 months ago by Johnni Winther
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Sort MessageKinds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 2 chunks +32 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Johnni Winther
4 years, 10 months ago (2016-02-01 09:33:16 UTC) #2
Johnni Winther
Ping
4 years, 10 months ago (2016-02-04 08:51:55 UTC) #3
Johnni Winther
PTAL
4 years, 10 months ago (2016-02-05 15:09:53 UTC) #5
floitsch
LGTM.
4 years, 10 months ago (2016-02-05 16:34:39 UTC) #6
Siggi Cherem (dart-lang)
lgtm
4 years, 10 months ago (2016-02-05 23:23:37 UTC) #8
Jacob
lgtm
4 years, 10 months ago (2016-02-06 00:48:40 UTC) #9
Johnni Winther
4 years, 10 months ago (2016-02-08 11:57:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d97da6f22582400e76c22347225eccd9dfdaa786 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698