Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 165193002: [Telemetry] Fix --cold-load-percent. (Closed)

Created:
6 years, 10 months ago by tonyg
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Fix --cold-load-percent. Previously, we didn't properly clear all the network caches. 1. DNS and predictor caches were left in tact. This was fixed by calling the net benchmarking extension methods. 2. Live resources in the memory cache were left in tact. This is fixed by navigating to about:blank to destroy the old renderer. Also, --enable-net-benchmarking is supported on the stable channel, so we can remove the workaround. With this, cold loads are consistent on Android: *RESULT cold_times: page_load_time= [4637,4493,4479,4564,4611,4549] ms Avg cold_times: 4555.500000ms Sd cold_times: 62.602716ms RESULT warm_times_by_url: http___www.youtube.com_watch?v_LIJOhk6FscY= [2122,2104,2079,2094] ms Avg warm_times_by_url: 2099.750000ms Sd warm_times_by_url: 18.043928ms BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251252

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M tools/perf/measurements/page_cycler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/page_cycler_unittest.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 3 chunks +0 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/core/tab.py View 1 chunk +18 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tonyg
6 years, 10 months ago (2014-02-13 23:27:28 UTC) #1
shatch
On 2014/02/13 23:27:28, tonyg wrote: Awesome! Patched it in here, getting much "colder" cold times, ...
6 years, 10 months ago (2014-02-13 23:44:25 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 10 months ago (2014-02-13 23:44:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/165193002/1
6 years, 10 months ago (2014-02-13 23:46:20 UTC) #4
slamm
https://codereview.chromium.org/165193002/diff/1/tools/telemetry/telemetry/core/tab.py File tools/telemetry/telemetry/core/tab.py (right): https://codereview.chromium.org/165193002/diff/1/tools/telemetry/telemetry/core/tab.py#newcode273 tools/telemetry/telemetry/core/tab.py:273: self.Navigate('about:blank') Does this need to be before the clearCache ...
6 years, 10 months ago (2014-02-14 00:15:33 UTC) #5
tonyg
On 2014/02/14 00:15:33, slamm wrote: > https://codereview.chromium.org/165193002/diff/1/tools/telemetry/telemetry/core/tab.py > File tools/telemetry/telemetry/core/tab.py (right): > > https://codereview.chromium.org/165193002/diff/1/tools/telemetry/telemetry/core/tab.py#newcode273 > ...
6 years, 10 months ago (2014-02-14 00:19:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 01:31:00 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=229543
6 years, 10 months ago (2014-02-14 01:31:04 UTC) #8
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 10 months ago (2014-02-14 01:45:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/165193002/150002
6 years, 10 months ago (2014-02-14 01:46:36 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 04:06:08 UTC) #11
Message was sent while issue was closed.
Change committed as 251252

Powered by Google App Engine
This is Rietveld 408576698