Issue 165192: With the recent NNTP changes, we change the way themes work - they're now clo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165192: With the recent NNTP changes, we change the way themes work - they're now clo... (Closed)

Created:
11 years, 4 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
arv (Not doing code reviews), Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

With the recent NNTP changes, we change the way themes work - they're now closer to NTP1 theming - ntp_section_* is used to control the display of the light blue sections, and we've added ntp_header that controls the dark blue hover color, ntp_header falls back to ntp_section if provided. Also fix a minor bug where the default theme was saving theme data - we were generating colors before saving the provided colors. BUG=18720, 18722 TEST=Install a theme and verify that the recently closed section is themed correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23081

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -32 lines)			Patch
M	chrome/browser/browser_theme_provider.h	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.cc	View	1 2	7 chunks	+24 lines, -6 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_theme_source.cc	View	1 2	2 chunks	+23 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View	1 2	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/resources/new_tab_theme.css	View	1 2	2 chunks	+13 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

LGTM. On 2009/08/08 00:39:02, Glen Murphy wrote: >

11 years, 4 months ago (2009-08-08 00:49:30 UTC) #2

arv (Not doing code reviews)

11 years, 4 months ago (2009-08-17 19:33:44 UTC) #3

I think this CL screws up the underline color of the links in the recently
closed.

Expand Messages | Collapse Messages

Issue 165192: With the recent NNTP changes, we change the way themes work - they're now clo... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages