Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: webkit/support/webkit_support.cc

Issue 16519003: Define a LoggingSettings struct to use for InitLogging() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile error Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/examples/content_client/examples_main_delegate.cc ('k') | win8/metro_driver/metro_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/support/webkit_support.cc
diff --git a/webkit/support/webkit_support.cc b/webkit/support/webkit_support.cc
index 8c8961f85bd175cdeb7f61b2db8672ab0a8fe07c..0e0997fd77fe8ce8d6b0a88d49b5a4f31340b545 100644
--- a/webkit/support/webkit_support.cc
+++ b/webkit/support/webkit_support.cc
@@ -116,15 +116,13 @@ void InitLogging() {
base::FilePath log_filename;
PathService::Get(base::DIR_EXE, &log_filename);
log_filename = log_filename.AppendASCII("DumpRenderTree.log");
- logging::InitLogging(
- log_filename.value().c_str(),
- // Only log to a file. This prevents debugging output from disrupting
- // whether or not we pass.
- logging::LOG_ONLY_TO_FILE,
- // We might have multiple DumpRenderTree processes going at once.
- logging::LOCK_LOG_FILE,
- logging::DELETE_OLD_LOG_FILE,
- logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS);
+ logging::LoggingSettings settings;
+ // Only log to a file. This prevents debugging output from disrupting
+ // whether or not we pass.
+ settings.logging_dest = logging::LOG_TO_FILE;
+ settings.log_file = log_filename.value().c_str();
+ settings.delete_old = logging::DELETE_OLD_LOG_FILE;
+ logging::InitLogging(settings);
// We want process and thread IDs because we may have multiple processes.
const bool kProcessId = true;
« no previous file with comments | « ui/views/examples/content_client/examples_main_delegate.cc ('k') | win8/metro_driver/metro_driver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698