Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: jingle/glue/logging_unittest.cc

Issue 16519003: Define a LoggingSettings struct to use for InitLogging() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile error Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/courgette_tool.cc ('k') | media/tools/media_bench/media_bench.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: jingle/glue/logging_unittest.cc
diff --git a/jingle/glue/logging_unittest.cc b/jingle/glue/logging_unittest.cc
index a9f0d8e24ccceca0c13ba184357df1b52410b20b..85ac558ca3c0a56caf2525f2d05caa2f274406fb 100644
--- a/jingle/glue/logging_unittest.cc
+++ b/jingle/glue/logging_unittest.cc
@@ -58,9 +58,12 @@ static bool Initialize(int verbosity_level) {
}
// The command line flags are parsed here and the log file name is set.
- if (!InitLogging(log_file_name, logging::LOG_ONLY_TO_FILE,
- logging::DONT_LOCK_LOG_FILE, logging::DELETE_OLD_LOG_FILE,
- logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS)) {
+ logging::LoggingSettings settings;
+ settings.logging_dest = logging::LOG_TO_FILE;
+ settings.log_file = log_file_name;
+ settings.lock_log = logging::DONT_LOCK_LOG_FILE;
+ settings.delete_old = logging::DELETE_OLD_LOG_FILE;
+ if (!logging::InitLogging(settings)) {
return false;
}
EXPECT_TRUE(VLOG_IS_ON(verbosity_level));
« no previous file with comments | « courgette/courgette_tool.cc ('k') | media/tools/media_bench/media_bench.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698