chrome/installer/gcapi/gcapi_dll.cc - Issue 16519003: Define a LoggingSettings struct to use for InitLogging()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/gcapi/gcapi_dll.cc

Issue 16519003: Define a LoggingSettings struct to use for InitLogging() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile error Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/gcapi/gcapi_dll.cc

diff --git a/chrome/installer/gcapi/gcapi_dll.cc b/chrome/installer/gcapi/gcapi_dll.cc

index 744321a516ae41b35dde5ab7c72dd06d784b4f4b..cb512e40b0c6be0425598d8d6cb2cb5e6b9a7508 100644

--- a/chrome/installer/gcapi/gcapi_dll.cc

+++ b/chrome/installer/gcapi/gcapi_dll.cc

@@ -22,12 +22,9 @@ extern "C" BOOL WINAPI DllMain(HINSTANCE instance,

if (reason == DLL_PROCESS_ATTACH) {

g_exit_manager = new base::AtExitManager();

CommandLine::Init(0, NULL);

- logging::InitLogging(

- NULL,

- logging::LOG_ONLY_TO_SYSTEM_DEBUG_LOG,

- logging::LOCK_LOG_FILE,

- logging::DELETE_OLD_LOG_FILE,

- logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS);

+ logging::LoggingSettings settings;

+ settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;

+ logging::InitLogging(settings);

} else if (reason == DLL_PROCESS_DETACH) {

CommandLine::Reset();

delete g_exit_manager;